Move some class-scope constants to file-scope in the lone subclass using them.

Move some class-scope constants to file-scope in the lone subclass using them.

This will make future changes clearer when these are replaced by runtime-
computed values.

This also changes the layout constants from const to constexpr, so I can make
the new file-scope constants constexpr.  Of course, that won't be needed after
the change above, but it's a reasonable change to make anyway, so going ahead.

BUG=686285
TEST=none

Review-Url: https://codereview.chromium.org/2669503002
Cr-Commit-Position: refs/heads/master@{#447202}
Committed: https://chromium.googlesource.com/chromium/src/+/d62cf13204608ddc4d54a2dc5bbb10abb9fdb0f4

[Peter Kasting, 2017-01-31 02:52:32]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:53:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-01-31 02:57:04]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2017-01-31 02:57:12]

Description was changed from

==========
Move some class-scope onstants to file-scope in the lone subclass using them.

This will make future changes clearer when these are replaced by runtime-
computed values.

This also changes the layout constants from const to constexpr, so I can make
the new file-scope constants constexpr.  Of course, that won't be needed after
the change above, but it's a reasonable change to make anyway, so going ahead.

BUG=686285
TEST=none
==========

to

==========
Move some class-scope constants to file-scope in the lone subclass using them.

This will make future changes clearer when these are replaced by runtime-
computed values.

This also changes the layout constants from const to constexpr, so I can make
the new file-scope constants constexpr.  Of course, that won't be needed after
the change above, but it's a reasonable change to make anyway, so going ahead.

BUG=686285
TEST=none
==========

[commit-bot: I haz the power, 2017-01-31 03:48:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:48:27]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-31 05:18:36]

LGTM

[Peter Kasting, 2017-01-31 06:52:59]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-01-31 06:53:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 06:56:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485845579516330, "parent_rev":
"a2c4dd1ab5ba1423bdb46bd4b0111b942ad5f3fb", "commit_rev":
"d62cf13204608ddc4d54a2dc5bbb10abb9fdb0f4"}

[commit-bot: I haz the power, 2017-01-31 06:57:30]

Description was changed from

==========
Move some class-scope constants to file-scope in the lone subclass using them.

This will make future changes clearer when these are replaced by runtime-
computed values.

This also changes the layout constants from const to constexpr, so I can make
the new file-scope constants constexpr.  Of course, that won't be needed after
the change above, but it's a reasonable change to make anyway, so going ahead.

BUG=686285
TEST=none
==========

to

==========
Move some class-scope constants to file-scope in the lone subclass using them.

This will make future changes clearer when these are replaced by runtime-
computed values.

This also changes the layout constants from const to constexpr, so I can make
the new file-scope constants constexpr.  Of course, that won't be needed after
the change above, but it's a reasonable change to make anyway, so going ahead.

BUG=686285
TEST=none

Review-Url: https://codereview.chromium.org/2669503002
Cr-Commit-Position: refs/heads/master@{#447202}
Committed:
https://chromium.googlesource.com/chromium/src/+/d62cf13204608ddc4d54a2dc5bbb...
==========

[commit-bot: I haz the power, 2017-01-31 06:57:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d62cf13204608ddc4d54a2dc5bbb...