Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2669463002: [Extensions] Remove BaseFeatureProvider (Closed)

Created:
3 years, 10 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
lazyboy, wastinglife15
CC:
chromium-reviews, extensions-reviews_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove BaseFeatureProvider BaseFeatureProvider is the implementation of FeatureProvider, but it's also the only implementation. Simply combine it and FeatureProvider, and remove BaseFeatureProvider and its references. BUG=686958 TEST=None, no functional change Review-Url: https://codereview.chromium.org/2669463002 Cr-Commit-Position: refs/heads/master@{#447231} Committed: https://chromium.googlesource.com/chromium/src/+/68806fb06d73fe2867a7063ef29654406a0c5819

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -349 lines) Patch
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 1 comment Download
M extensions/browser/api/system_cpu/system_cpu_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/_behavior_features.json View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/_manifest_features.json View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download
D extensions/common/features/base_feature_provider.h View 1 chunk +0 lines, -56 lines 0 comments Download
D extensions/common/features/base_feature_provider.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D extensions/common/features/base_feature_provider_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M extensions/common/features/feature_provider.h View 3 chunks +19 lines, -14 lines 0 comments Download
M extensions/common/features/feature_provider.cc View 3 chunks +60 lines, -0 lines 0 comments Download
A + extensions/common/features/feature_provider_unittest.cc View 6 chunks +35 lines, -30 lines 0 comments Download
M extensions/common/features/simple_feature.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/common/api/_api_features.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/feature_compiler.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Devlin
3 years, 10 months ago (2017-01-31 01:58:37 UTC) #4
lazyboy
lgtm
3 years, 10 months ago (2017-01-31 05:32:21 UTC) #7
wastinglife15
On 2017/01/31 05:32:21, lazyboy wrote: > lgtm Rite
3 years, 10 months ago (2017-01-31 05:51:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669463002/1
3 years, 10 months ago (2017-01-31 14:25:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/68806fb06d73fe2867a7063ef29654406a0c5819
3 years, 10 months ago (2017-01-31 14:31:12 UTC) #13
wastinglife15
lgtm
3 years, 9 months ago (2017-03-17 15:46:32 UTC) #15
wastinglife15
3 years, 9 months ago (2017-03-17 16:05:31 UTC) #16
Message was sent while issue was closed.
Fuck you

https://codereview.chromium.org/2669463002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/2669463002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:953: "whitelist": [
Fuck you cunt

Powered by Google App Engine
This is Rietveld 408576698