Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2669423002: Add test case for built-in objects' property mode. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add test case for built-in objects' property mode. R=jgruber@chromium.org BUG=v8:5902 Review-Url: https://codereview.chromium.org/2669423002 Cr-Commit-Position: refs/heads/master@{#42922} Committed: https://chromium.googlesource.com/v8/v8/+/b963cb2351f354d13bbc32277d0a7233c2459ae7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
A test/mjsunit/regress/regress-5902.js View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Yang
3 years, 10 months ago (2017-02-03 08:22:19 UTC) #1
jgruber
lgtm, great to have this.
3 years, 10 months ago (2017-02-03 08:25:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669423002/1
3 years, 10 months ago (2017-02-03 12:17:03 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 12:19:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b963cb2351f354d13bbc32277d0a7233c24...

Powered by Google App Engine
This is Rietveld 408576698