Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2669403002: Move tests for sections elements to html/sections/. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests for sections elements to html/sections/. This CL moves test for the following elements: BODY, ARTICLE, SECTION, NAV, ASIDE, H1, H2, H3, H4, H5, H6, HGROUP, HEADER, and FOOTER. This CL has no behaivor changes. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2669403002 Cr-Commit-Position: refs/heads/master@{#447959} Committed: https://chromium.googlesource.com/chromium/src/+/d6e50d4b7dec6e8aff173a1fd567758973b65130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-26 lines, -1289 lines) Patch
M third_party/WebKit/LayoutTests/SmokeTests View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLBodyElement/body-inserting-iframe-crash.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLBodyElement/body-inserting-iframe-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLBodyElement/body-legacy-colors.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLBodyElement/body-legacy-colors-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/body-clone-link-decl-parent-crash.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/body-clone-link-decl-parent-crash-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/body-frameset-event-handlers.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size.html View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/body-quirk-client-size-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/global-event-handlers.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/remove-body-during-body-replacement.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/remove-body-during-body-replacement-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/remove-body-during-body-replacement2.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/remove-body-during-body-replacement2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/remove-body-during-title-creation.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/remove-body-during-title-creation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/resources/event-handlers.js View 1 chunk +0 lines, -91 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/window-event-handlers.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/article-element.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/article-element-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/aside-element.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/aside-element-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/body-offset-properties.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/body-offset-properties-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/footer-element.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/footer-element-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/header-element.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/header-element-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/hgroup-element.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/hgroup-element-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/nav-element.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/nav-element-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/numbered-header-element.html View 1 chunk +0 lines, -249 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/numbered-header-element-expected.txt View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/section-element.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/section-element-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/resources/event-handlers.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/article-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/article-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/aside-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/aside-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-clone-link-decl-parent-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-clone-link-decl-parent-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-frameset-event-handlers.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-inserting-iframe-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-inserting-iframe-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-legacy-colors.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-legacy-colors-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-offset-properties.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-offset-properties-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-quirk-client-size.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/body-quirk-client-size-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/footer-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/footer-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/header-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/header-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/hgroup-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/hgroup-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/nav-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/nav-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/numbered-header-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/numbered-header-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/remove-body-during-body-replacement.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/remove-body-during-body-replacement-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/remove-body-during-body-replacement2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/remove-body-during-body-replacement2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/remove-body-during-title-creation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/remove-body-during-title-creation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/section-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/sections/section-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/html/article-element-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/html/body-offset-properties-expected.png View Binary file 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
3 years, 10 months ago (2017-02-03 07:19:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669403002/1
3 years, 10 months ago (2017-02-03 07:19:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d6e50d4b7dec6e8aff173a1fd567758973b65130
3 years, 10 months ago (2017-02-03 07:38:39 UTC) #11
kochi
3 years, 10 months ago (2017-02-03 08:19:27 UTC) #12
Message was sent while issue was closed.
rs lgtm

Good to know there is "SmokeTest" file :)

Powered by Google App Engine
This is Rietveld 408576698