Add support for [TreatNullAs] extended attribute for reflected attributes

Add support for [TreatNullAs] extended attribute for reflected attributes

Add support for [TreatNullAs] extended attribute for reflected attributes and fix the
bindings generator so that [Reflect] no longer implies [TreatNullAs=NullString].
This way, newly introduced reflected attributes will behave according to specification.

This CL adds [TreatNullAs=NullString] extended attribute to all existing reflected
attributes of type DOMString so that there is no web-exposed behavior change. This
makes it more explicit that we treat null as the Null string for those attributes and
it makes it clear that we don't match the specifications in many cases.

In follow-up patches, we should gradually remove those [TreatNullAs=NullString]
extended attributes for reflected attributes when the specification does not indicate
[TreatNullAs=EmptyString] and when other browser behave according to the
specification.

R=arv, haraken
BUG=304959
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159260

[arv (Not doing code reviews), 2013-10-09 14:55:18]

LGTM

https://codereview.chromium.org/26694003/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/26694003/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:1843: my $mode = "";
Can this be extracted to a function.

sub GetStringResourceMode {
    my $extendedAttributes = shift;
    if (($extendedAttributes->{"TreatNullAs"} and
$extendedAttributes->{"TreatNullAs"} eq "NullString") and
($extendedAttributes->{"TreatUndefinedAs"} and
$extendedAttributes->{"TreatUndefinedAs"} eq "NullString")) {
        return "WithUndefinedOrNullCheck";
    } elsif (($extendedAttributes->{"TreatNullAs"} and
$extendedAttributes->{"TreatNullAs"} eq "NullString") or
$extendedAttributes->{"Reflect"}) {
        return "WithNullCheck";
    }
    return "";
}

and used here and in GetNativeType?

[Inactive, 2013-10-09 15:17:40]

https://codereview.chromium.org/26694003/diff/1/Source/bindings/scripts/code_...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/26694003/diff/1/Source/bindings/scripts/code_...
Source/bindings/scripts/code_generator_v8.pm:1843: my $mode = "";
On 2013/10/09 14:55:19, arv wrote:
> Can this be extracted to a function.
> 
> sub GetStringResourceMode {
>     my $extendedAttributes = shift;
>     if (($extendedAttributes->{"TreatNullAs"} and
> $extendedAttributes->{"TreatNullAs"} eq "NullString") and
> ($extendedAttributes->{"TreatUndefinedAs"} and
> $extendedAttributes->{"TreatUndefinedAs"} eq "NullString")) {
>         return "WithUndefinedOrNullCheck";
>     } elsif (($extendedAttributes->{"TreatNullAs"} and
> $extendedAttributes->{"TreatNullAs"} eq "NullString") or
> $extendedAttributes->{"Reflect"}) {
>         return "WithNullCheck";
>     }
>     return "";
> }
> 
> and used here and in GetNativeType?

Done.

[arv (Not doing code reviews), 2013-10-09 15:32:48]

Thanks

Even more LGTM

[commit-bot: I haz the power, 2013-10-09 17:02:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26694003/7001

[commit-bot: I haz the power, 2013-10-09 21:05:12]

Change committed as 159260

[haraken, 2013-10-09 22:08:43]

LGTM

[philipj_slow, 2013-10-10 07:46:03]

This change accidentally (?) added this in HTMLMediaElement.idl:

[Reflect, TreatNullAs=NullString, TreatNullAs=NullString] attribute DOMString
mediaGroup;

I'll drop the duplicate in <https://codereview.chromium.org/26759003/>, but you
might want to check if there are more such cases.

[do-not-use, 2013-10-10 12:55:40]

On 2013/10/10 07:46:03, philipj wrote:
> This change accidentally (?) added this in HTMLMediaElement.idl:
> 
> [Reflect, TreatNullAs=NullString, TreatNullAs=NullString] attribute DOMString
> mediaGroup;
> 
> I'll drop the duplicate in <https://codereview.chromium.org/26759003/>, but
you
> might want to check if there are more such cases.

Thanks for notifying me. I'll check today.

[Inactive, 2013-10-10 13:24:30]

On 2013/10/10 12:55:40, Christophe Dumez wrote:
> On 2013/10/10 07:46:03, philipj wrote:
> > This change accidentally (?) added this in HTMLMediaElement.idl:
> > 
> > [Reflect, TreatNullAs=NullString, TreatNullAs=NullString] attribute
DOMString
> > mediaGroup;
> > 
> > I'll drop the duplicate in <https://codereview.chromium.org/26759003/>, but
> you
> > might want to check if there are more such cases.
> 
> Thanks for notifying me. I'll check today.

I checked, I couldn't find any other bad duplicates.