Add support for [TreatNullAs] extended attribute for reflected attributes

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 1822 matching lines @@
     } elsif ($attrExt->{"OnProto"}) {
         $code .= <<END;
     ${implClassName}* imp = ${v8ClassName}::toNative(info.Holder());
 END
     } else {
         my $reflect = $attribute->extendedAttributes->{"Reflect"};
         if ($reflect && InheritsInterface($interface, "Node") && $attrType eq "DOMString") {
             # Generate super-compact call for regular attribute setter:
             my $contentAttributeName = $reflect eq "VALUE_IS_MISSING" ? lc $attrName : $reflect;
             my $namespace = NamespaceForAttributeName($interfaceName, $contentAttributeName);
+            my $mode = "";

[arv (Not doing code reviews), 2013/10/09 14:55:19]

Can this be extracted to a function.

sub GetStringResourceMode {
    my $extendedAttributes = shift;
    if (($extendedAttributes->{"TreatNullAs"} and
$extendedAttributes->{"TreatNullAs"} eq "NullString") and
($extendedAttributes->{"TreatUndefinedAs"} and
$extendedAttributes->{"TreatUndefinedAs"} eq "NullString")) {
        return "WithUndefinedOrNullCheck";
    } elsif (($extendedAttributes->{"TreatNullAs"} and
$extendedAttributes->{"TreatNullAs"} eq "NullString") or
$extendedAttributes->{"Reflect"}) {
        return "WithNullCheck";
    }
    return "";
}

and used here and in GetNativeType?

[Inactive, 2013/10/09 15:17:41]

Done.

+            if (($attribute->extendedAttributes->{"TreatNullAs"} and $attribute->extendedAttributes->{"TreatNullAs"} eq "NullString") and ($attribute->extendedAttributes->{"TreatUndefinedAs"} and $attribute->extendedAttributes->{"TreatUndefinedAs"} eq "NullString")) {
+                $mode = "WithUndefinedOrNullCheck";
+            } elsif ($attribute->extendedAttributes->{"TreatNullAs"} and $attribute->extendedAttributes->{"TreatNullAs"} eq "NullString") {
+                $mode = "WithNullCheck";
+            }
             AddToImplIncludes("${namespace}.h");
             $code .= "    Element* imp = V8Element::toNative(info.Holder());\n";
-            $code .= "    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, stringResource, value);\n";
+            $code .= "    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<$mode>, stringResource, value);\n";
             # Attr (not Attribute) used in content attributes
             $code .= "    imp->setAttribute(${namespace}::${contentAttributeName}Attr, stringResource);\n";
             $code .= "}\n\n";
             $code .= "#endif // ${conditionalString}\n\n" if $conditionalString;
             $implementation{nameSpaceInternal}->add($code);
             return;
             # Skip the rest of the function!
         }
 
         if (!$attribute->isStatic) {
@@ skipping 3277 matching lines @@
     return "bool" if $type eq "boolean";
 
     if (($type eq "DOMString" || IsEnumType($type)) and $isParameter) {
         # Blink uses the non-standard identifier NullString instead of Web IDL
         # standard EmptyString, in [TreatNullAs=NullString] and [TreatUndefinedAs=NullString],
         # and does not support [TreatUndefinedAs=Null] or [TreatUndefinedAs=Missing]
         # https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-TreatNullAs-a-p-TreatUndefinedAs-a-p-
         my $mode = "";
         if (($extendedAttributes->{"TreatNullAs"} and $extendedAttributes->{"TreatNullAs"} eq "NullString") and ($extendedAttributes->{"TreatUndefinedAs"} and $extendedAttributes->{"TreatUndefinedAs"} eq "NullString")) {
             $mode = "WithUndefinedOrNullCheck";
-        } elsif (($extendedAttributes->{"TreatNullAs"} and $extendedAttributes->{"TreatNullAs"} eq "NullString") or $extendedAttributes->{"Reflect"}) {
+        } elsif ($extendedAttributes->{"TreatNullAs"} and $extendedAttributes->{"TreatNullAs"} eq "NullString") {
             $mode = "WithNullCheck";
         }
         # FIXME: Add the case for 'elsif ($attributeOrParameter->extendedAttributes->{"TreatUndefinedAs"} and $attributeOrParameter->extendedAttributes->{"TreatUndefinedAs"} eq "NullString"))'.
         return "V8StringResource<$mode>";
     }
 
     return "String" if $type eq "DOMString" or IsEnumType($type);
 
     return "ScriptPromise" if $type eq "Promise";
 
@@ skipping 1002 matching lines @@
     my $interface = shift;
 
     return 1 if $interface->extendedAttributes->{"CustomToV8"};
     return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
     return 1 if InheritsInterface($interface, "Document");
 
     return 0;
 }
 
 1;