[inspector] fixed taskHeapSnapshot on pause

[inspector] fixed taskHeapSnapshot on pause

Blink uses access checks to be sure that objects from one context doesn't access objects in another. Heap profiler uses current context to call this checks, we need to be sure that current context is empty to allow heap profiler collect all objects without crash.

BUG=chromium:661223
R=alph@chromium.org,ulan@chromium.org

Review-Url: https://codereview.chromium.org/2669393002
Cr-Commit-Position: refs/heads/master@{#42939}
Committed: https://chromium.googlesource.com/v8/v8/+/39afa5af0682e43a1f1175bc39225168860d556b

[kozy, 2017-02-03 03:19:11]

Description was changed from

==========
[inspector] fixed taskHeapSnapshot on pause

BUG=none
R=alph@chromium.org,ulan@chromium.org
==========

to

==========
[inspector] fixed taskHeapSnapshot on pause

Blink uses access checks to be sure that objects from one context doesn't access
objects in another. Heap profiler uses current context to call this checks, we
need to be sure that current context is empty to allow heap profiler collect all
objects without crash.

BUG=none
R=alph@chromium.org,ulan@chromium.org
==========

[kozy, 2017-02-03 03:19:27]

Ulan and Alexey, please take a look!

[ulan, 2017-02-03 03:21:52]

lgtm!

[alph, 2017-02-03 22:54:01]

Great! Thank you and Ulan for digging into it.
There's a bug about it,
https://bugs.chromium.org/p/chromium/issues/detail?id=661223

LGTM

[kozy, 2017-02-03 23:09:06]

Description was changed from

==========
[inspector] fixed taskHeapSnapshot on pause

Blink uses access checks to be sure that objects from one context doesn't access
objects in another. Heap profiler uses current context to call this checks, we
need to be sure that current context is empty to allow heap profiler collect all
objects without crash.

BUG=none
R=alph@chromium.org,ulan@chromium.org
==========

to

==========
[inspector] fixed taskHeapSnapshot on pause

Blink uses access checks to be sure that objects from one context doesn't access
objects in another. Heap profiler uses current context to call this checks, we
need to be sure that current context is empty to allow heap profiler collect all
objects without crash.

BUG=chromium:661223
R=alph@chromium.org,ulan@chromium.org
==========

[kozy, 2017-02-03 23:49:00]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-03 23:49:01]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2669393002/#ps20001
(title: "improved test")

[commit-bot: I haz the power, 2017-02-03 23:49:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:13:13]

Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20422)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[kozy, 2017-02-04 00:17:10]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:17:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:36:32]

Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20427)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[kozy, 2017-02-04 00:49:34]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-04 00:49:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2669393002/#ps60001
(title: "updated test expectations")

[commit-bot: I haz the power, 2017-02-04 00:49:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-02-04 00:50:34]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-02-04 01:21:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486169374776940,
"parent_rev": "79837f5f6f269cf3579b10d403396b742786fcff", "commit_rev":
"39afa5af0682e43a1f1175bc39225168860d556b"}

[commit-bot: I haz the power, 2017-02-04 01:22:03]

Description was changed from

==========
[inspector] fixed taskHeapSnapshot on pause

Blink uses access checks to be sure that objects from one context doesn't access
objects in another. Heap profiler uses current context to call this checks, we
need to be sure that current context is empty to allow heap profiler collect all
objects without crash.

BUG=chromium:661223
R=alph@chromium.org,ulan@chromium.org
==========

to

==========
[inspector] fixed taskHeapSnapshot on pause

Blink uses access checks to be sure that objects from one context doesn't access
objects in another. Heap profiler uses current context to call this checks, we
need to be sure that current context is empty to allow heap profiler collect all
objects without crash.

BUG=chromium:661223
R=alph@chromium.org,ulan@chromium.org

Review-Url: https://codereview.chromium.org/2669393002
Cr-Commit-Position: refs/heads/master@{#42939}
Committed:
https://chromium.googlesource.com/v8/v8/+/39afa5af0682e43a1f1175bc39225168860...
==========

[commit-bot: I haz the power, 2017-02-04 01:22:05]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/39afa5af0682e43a1f1175bc39225168860...