Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2669383002: [Merge M57] Sets label's layout params to sublabel only when label and (Closed)

Created:
3 years, 10 months ago by csashi
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org, estark
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] Sets label's layout params to sublabel only when label and sublabel are not on the same line. NOTRY=true NOPRESUBMIT=true BUG=687395 Review-Url: https://codereview.chromium.org/2669383002 Cr-Commit-Position: refs/branch-heads/2987@{#289} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/476ab0350f600f46717bb4ebd392cc0b4c442d65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ui/android/java/src/org/chromium/ui/DropdownAdapter.java View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669383002/1
3 years, 10 months ago (2017-02-03 04:47:37 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-03 04:47:38 UTC) #4
csashi
On 2017/02/03 04:47:38, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-03 04:49:02 UTC) #7
Ted C
On 2017/02/03 04:49:02, csashi wrote: > On 2017/02/03 04:47:38, commit-bot: I haz the power wrote: ...
3 years, 10 months ago (2017-02-03 17:15:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669383002/1
3 years, 10 months ago (2017-02-03 17:16:36 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 17:34:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/476ab0350f600f46717bb4ebd392...

Powered by Google App Engine
This is Rietveld 408576698