desktop-views: Create one fewer aura::Window for each widget.

desktop-views: Create one fewer aura::Window for each widget.

For each views::Widget, a DesktopNativeWidgetAura is created, which
creates two windows: |content_window_|, and |content_window_container_|.
But the DesktopWindowTreeHostMus' root-window can be the container for
|content_window_|, and a separate container window is not needed. So
remove that.

BUG=none

Review-Url: https://codereview.chromium.org/2669303005
Cr-Commit-Position: refs/heads/master@{#448204}
Committed: https://chromium.googlesource.com/chromium/src/+/5d64ae77225a34b5e439216e5cf3ea643b9ea29b

[sadrul, 2017-02-03 01:19:12]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 01:19:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 02:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 02:16:05]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-02-03 02:50:45]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2017-02-03 02:50:45]

In mustash mode, because of this extra window, we end up creating two windows in
ash (and mus-ws, of course) for each remote Widget, which seems wasteful. Also,
although the Window in the client is NOT_DRAWN, the corresponding one created in
ash is not. As I looked into making sure the window in ash is NOT_DRAWN, it made
sense to just not create the window, since I can't think of (or remember) a good
reason to have this window anyway. WDYT? The trybots seem happy. Is there
anything you can think of that this would break?

[sky, 2017-02-03 17:30:58]

This was done for tooltips:
https://chromium.googlesource.com/chromium/src/+/cc90e1bc08807efd864c7656be6f...
. Did you make sure there aren't any regressions because of it? I suspect not as
I think that code was before we switched to using the native tooltips on
windows. Assuming this code isn't necessary I think you can likely remove some
other code that landed in that patch.

[sadrul, 2017-02-04 00:03:45]

On 2017/02/03 17:30:58, sky wrote:
> This was done for tooltips:
>
https://chromium.googlesource.com/chromium/src/+/cc90e1bc08807efd864c7656be6f...
> . Did you make sure there aren't any regressions because of it? I suspect not
as
> I think that code was before we switched to using the native tooltips on
> windows. Assuming this code isn't necessary I think you can likely remove some
> other code that landed in that patch.

I tried it out on linux and windows, and I couldn't find any obvious
regressions. Tooltips, for example, work OK. So does activation etc.

I wasn't able to clean-up any additional code. DesktopFocusRules has grown since
then. I was able to simplify a little one of the functions in there though. PTAL

[sadrul, 2017-02-04 00:06:12]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 00:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:50:33]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-04 22:22:54]

LGTM - Was this causing any problems in the mash case?

[sadrul, 2017-02-05 21:46:11]

On 2017/02/04 22:22:54, sky wrote:
> LGTM - Was this causing any problems in the mash case?

Not yet, but we would have to fix the window in ash to be NOT_DRAWN to reduce
overdraw.

[sadrul, 2017-02-06 01:26:35]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-02-06 01:26:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 02:18:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486344395372530,
"parent_rev": "aca84dc37eb032e7ed985a19597a233b6f491fcc", "commit_rev":
"5d64ae77225a34b5e439216e5cf3ea643b9ea29b"}

[commit-bot: I haz the power, 2017-02-06 02:20:11]

Description was changed from

==========
desktop-views: Create one fewer aura::Window for each widget.

For each views::Widget, a DesktopNativeWidgetAura is created, which
creates two windows: |content_window_|, and |content_window_container_|.
But the DesktopWindowTreeHostMus' root-window can be the container for
|content_window_|, and a separate container window is not needed. So
remove that.

BUG=none
==========

to

==========
desktop-views: Create one fewer aura::Window for each widget.

For each views::Widget, a DesktopNativeWidgetAura is created, which
creates two windows: |content_window_|, and |content_window_container_|.
But the DesktopWindowTreeHostMus' root-window can be the container for
|content_window_|, and a separate container window is not needed. So
remove that.

BUG=none

Review-Url: https://codereview.chromium.org/2669303005
Cr-Commit-Position: refs/heads/master@{#448204}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d64ae77225a34b5e439216e5cf3...
==========

[commit-bot: I haz the power, 2017-02-06 02:20:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d64ae77225a34b5e439216e5cf3...