ios/chrome/browser/web/window_open_by_dom_egtest.mm - Issue 2669303004: Removed externalRequest code from CRWWebController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/window_open_by_dom_egtest.mm

Issue 2669303004: Removed externalRequest code from CRWWebController. (Closed)

Patch Set: Merged Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/window_open_by_dom_egtest.mm

diff --git a/ios/chrome/browser/web/window_open_by_dom_egtest.mm b/ios/chrome/browser/web/window_open_by_dom_egtest.mm

index 91dd4fa74071b3128343df6480a3a00568db3298..3c606f6d22e48d0e633cfaca27736e1d888f97de 100644

--- a/ios/chrome/browser/web/window_open_by_dom_egtest.mm

+++ b/ios/chrome/browser/web/window_open_by_dom_egtest.mm

@@ -62,8 +62,7 @@ const char kTestURL[] =

// Tests that |sessionStorage| content is available for windows opened by DOM

// via |target="_blank"| links.

-// TODO(crbug.com/681434): Enable this test.

-- (void)DISABLED_testLinkWithBlankTargetSessionStorage {

+- (void)testLinkWithBlankTargetSessionStorage {

using chrome_test_util::ExecuteJavaScript;

NSError* error = nil;