ios/chrome/browser/web/browsing_egtest.mm - Issue 2669303004: Removed externalRequest code from CRWWebController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/browsing_egtest.mm

Issue 2669303004: Removed externalRequest code from CRWWebController. (Closed)

Patch Set: Merged Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/browsing_egtest.mm

diff --git a/ios/chrome/browser/web/browsing_egtest.mm b/ios/chrome/browser/web/browsing_egtest.mm

index bb7d3087a9217acbe1e0de281782589bc7afa6ea..24657f1b4dde8179fa29afda119600949a51ef04 100644

--- a/ios/chrome/browser/web/browsing_egtest.mm

+++ b/ios/chrome/browser/web/browsing_egtest.mm

@@ -279,7 +279,9 @@ id<GREYMatcher> GoButtonMatcher() {

// Tests that clicking a link with URL changed by onclick uses the href of the

// anchor tag instead of the one specified in JavaScript. Also verifies a new

// tab is opened by target '_blank'.

-- (void)testBrowsingPreventDefaultWithLinkOpenedByJavascript {

+// TODO(crbug.com/688223): WKWebView does not open a new window as expected by

+// this test.

+- (void)DISABLED_testBrowsingPreventDefaultWithLinkOpenedByJavascript {

// Create map of canned responses and set up the test HTML server.

std::map<GURL, std::string> responses;

const GURL URL = web::test::HttpServer::MakeUrl(