Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2669293003: [Android] Do not restrict the arguments to getsockopt. (Closed)

Created:
3 years, 10 months ago by Robert Sesek
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Do not restrict the arguments to getsockopt. They were previously un-restricted, and bd716dcb8575e046af147dd1b69f56090c77b4e4 regressed that. BUG=682488 R=jorgelo@chromium.org Review-Url: https://codereview.chromium.org/2669293003 Cr-Commit-Position: refs/heads/master@{#447995} Committed: https://chromium.googlesource.com/chromium/src/+/2d367b561d91f5f0c46724d66ea64852eadbb15a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (9 generated)
Robert Sesek
The revert refused to land, so here's the fix instead. Please cq if lg. https://codereview.chromium.org/2669293003/diff/1/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc ...
3 years, 10 months ago (2017-02-03 10:58:50 UTC) #5
Jorge Lucangeli Obes
lgtm
3 years, 10 months ago (2017-02-03 14:11:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669293003/1
3 years, 10 months ago (2017-02-03 14:14:58 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 14:41:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d367b561d91f5f0c46724d66ea6...

Powered by Google App Engine
This is Rietveld 408576698