Convert ConvolverNode tests to testharness

Convert ConvolverNode tests to testharness

Convert tests to use testharness.  convolver-channels.html was
converted by script but also needed a small manual change because of
testPassed/testFailed, but was otherwise unchanged.

The other tests were converted by hand.

BUG=688060
TEST=convolution-mono-mono.html, convolver-channels.html,
convolver-setBuffer-null.html

Review-Url: https://codereview.chromium.org/2669293002
Cr-Commit-Position: refs/heads/master@{#447872}
Committed: https://chromium.googlesource.com/chromium/src/+/4726f5b6b18b3ae44776ec2440248f96230a6eab

[Raymond Toy, 2017-02-02 18:45:14]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-02 18:45:14]

PTAL.

[hongchan, 2017-02-02 19:52:17]

lgtm

From the functional perspective, the change looks okay. However, we should not
use "success = success && something" pattern any more in the future. It
significantly worsens the readability of a test.

[Raymond Toy, 2017-02-02 20:43:16]

On 2017/02/02 19:52:17, hongchan wrote:
> lgtm
> 
> From the functional perspective, the change looks okay. However, we should not
> use "success = success && something" pattern any more in the future. It
> significantly worsens the readability of a test.

Agreed. I did that only to preserve the existing logic because the function
returned success. I didn't check to see if the result was actually used anymore.
 But these kinds of cleanups will come someday in another CL.

[Raymond Toy, 2017-02-02 21:57:14]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-02 21:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:26:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486072634236900,
"parent_rev": "e900021031992c3acd78379a1cd0994039fd7bd8", "commit_rev":
"4726f5b6b18b3ae44776ec2440248f96230a6eab"}

[commit-bot: I haz the power, 2017-02-02 23:26:39]

Description was changed from

==========
Convert ConvolverNode tests to testharness

Convert tests to use testharness.  convolver-channels.html was
converted by script but also needed a small manual change because of
testPassed/testFailed, but was otherwise unchanged.

The other tests were converted by hand.

BUG=688060
TEST=convolution-mono-mono.html, convolver-channels.html,
convolver-setBuffer-null.html
==========

to

==========
Convert ConvolverNode tests to testharness

Convert tests to use testharness.  convolver-channels.html was
converted by script but also needed a small manual change because of
testPassed/testFailed, but was otherwise unchanged.

The other tests were converted by hand.

BUG=688060
TEST=convolution-mono-mono.html, convolver-channels.html,
convolver-setBuffer-null.html

Review-Url: https://codereview.chromium.org/2669293002
Cr-Commit-Position: refs/heads/master@{#447872}
Committed:
https://chromium.googlesource.com/chromium/src/+/4726f5b6b18b3ae44776ec244024...
==========

[commit-bot: I haz the power, 2017-02-02 23:26:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4726f5b6b18b3ae44776ec244024...