Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2669293002: Convert ConvolverNode tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ConvolverNode tests to testharness Convert tests to use testharness. convolver-channels.html was converted by script but also needed a small manual change because of testPassed/testFailed, but was otherwise unchanged. The other tests were converted by hand. BUG=688060 TEST=convolution-mono-mono.html, convolver-channels.html, convolver-setBuffer-null.html Review-Url: https://codereview.chromium.org/2669293002 Cr-Commit-Position: refs/heads/master@{#447872} Committed: https://chromium.googlesource.com/chromium/src/+/4726f5b6b18b3ae44776ec2440248f96230a6eab

Patch Set 1 #

Patch Set 2 : Remove commented-out code #

Messages

Total messages: 9 (4 generated)
Raymond Toy
PTAL.
3 years, 10 months ago (2017-02-02 18:45:14 UTC) #2
hongchan
lgtm From the functional perspective, the change looks okay. However, we should not use "success ...
3 years, 10 months ago (2017-02-02 19:52:17 UTC) #3
Raymond Toy
On 2017/02/02 19:52:17, hongchan wrote: > lgtm > > From the functional perspective, the change ...
3 years, 10 months ago (2017-02-02 20:43:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669293002/20001
3 years, 10 months ago (2017-02-02 21:57:37 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 23:26:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4726f5b6b18b3ae44776ec244024...

Powered by Google App Engine
This is Rietveld 408576698