Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2669263006: Convert ScriptProcessor Audit tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ScriptProcessor Audit tests to testharness Converted using the script for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` if [ -f $base-expected.txt ]; then git rm $base-expected.txt fi done BUG=688493 TEST=scriptprocessornode-0-output-channels.html Review-Url: https://codereview.chromium.org/2669263006 Cr-Commit-Position: refs/heads/master@{#451368} Committed: https://chromium.googlesource.com/chromium/src/+/f5df21df7ccb7b4dcbff0c6d7f8c5f1e1276af31

Patch Set 1 #

Patch Set 2 : Remove finish task and some extra blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html View 1 2 chunks +3 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-0-output-channels-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-14 20:21:34 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-02-17 18:32:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669263006/20001
3 years, 10 months ago (2017-02-17 19:11:38 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 20:18:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f5df21df7ccb7b4dcbff0c6d7f8c...

Powered by Google App Engine
This is Rietveld 408576698