Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2669263004: binding: Updates a comment of the class string on the platform objects. (Closed)

Created:
3 years, 10 months ago by Yuki
Modified:
3 years, 10 months ago
Reviewers:
haraken, Matt Giuca
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Updates a comment of the class string on the platform objects. Describes our situation on the subject more clearly and correctly. BUG= Review-Url: https://codereview.chromium.org/2669263004 Cr-Commit-Position: refs/heads/master@{#450348} Committed: https://chromium.googlesource.com/chromium/src/+/23dec59945d8e6727d9aa5e83bc9b8ac56671e81

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 1 chunk +17 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yuki
Could you guys review this CL?
3 years, 10 months ago (2017-02-03 11:09:09 UTC) #2
haraken
LGTM
3 years, 10 months ago (2017-02-03 16:31:56 UTC) #3
Matt Giuca
I suggested some wording changes. LGTM with or without these changes. https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right): ...
3 years, 10 months ago (2017-02-05 23:18:08 UTC) #4
Yuki
https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right): https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp#newcode622 third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:622: // "Prototype", to the prototype object (|prototypeTemplate|), because we ...
3 years, 10 months ago (2017-02-14 12:58:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669263004/20001
3 years, 10 months ago (2017-02-14 12:59:11 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 14:30:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23dec59945d8e6727d9aa5e83bc9...

Powered by Google App Engine
This is Rietveld 408576698