binding: Updates a comment of the class string on the platform objects.

binding: Updates a comment of the class string on the platform objects.

Describes our situation on the subject more clearly and correctly.

BUG=

Review-Url: https://codereview.chromium.org/2669263004
Cr-Commit-Position: refs/heads/master@{#450348}
Committed: https://chromium.googlesource.com/chromium/src/+/23dec59945d8e6727d9aa5e83bc9b8ac56671e81

[Yuki, 2017-02-03 11:09:08]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org, mgiuca@chromium.org

[Yuki, 2017-02-03 11:09:09]

Could you guys review this CL?

[haraken, 2017-02-03 16:31:56]

LGTM

[Matt Giuca, 2017-02-05 23:18:08]

I suggested some wording changes.

LGTM with or without these changes.

https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:622: //
"Prototype", to the prototype object (|prototypeTemplate|), because we
It seems a bit strange out of context to be saying "without "Prototype""... why
would there be an expectation of it having "Prototype" at the end?

Perhaps add "(as required by the current WebIDL draft, as of February 2017)" or
something, to say basically this comment marks an explicit deviation from the
draft standard.

[Yuki, 2017-02-14 12:58:46]

https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/2669263004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:622: //
"Prototype", to the prototype object (|prototypeTemplate|), because we
On 2017/02/05 23:18:08, Matt Giuca wrote:
> It seems a bit strange out of context to be saying "without "Prototype""...
why
> would there be an expectation of it having "Prototype" at the end?
> 
> Perhaps add "(as required by the current WebIDL draft, as of February 2017)"
or
> something, to say basically this comment marks an explicit deviation from the
> draft standard.

Done.

[Yuki, 2017-02-14 12:58:55]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2017-02-14 12:58:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/2669263004/#ps20001
(title: "Addressed a review comment.")

[commit-bot: I haz the power, 2017-02-14 12:59:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 14:29:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487077135457830,
"parent_rev": "10d86e606392039058783321270ee6a8580da999", "commit_rev":
"23dec59945d8e6727d9aa5e83bc9b8ac56671e81"}

[commit-bot: I haz the power, 2017-02-14 14:30:04]

Description was changed from

==========
binding: Updates a comment of the class string on the platform objects.

Describes our situation on the subject more clearly and correctly.

BUG=
==========

to

==========
binding: Updates a comment of the class string on the platform objects.

Describes our situation on the subject more clearly and correctly.

BUG=

Review-Url: https://codereview.chromium.org/2669263004
Cr-Commit-Position: refs/heads/master@{#450348}
Committed:
https://chromium.googlesource.com/chromium/src/+/23dec59945d8e6727d9aa5e83bc9...
==========

[commit-bot: I haz the power, 2017-02-14 14:30:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23dec59945d8e6727d9aa5e83bc9...