Let clang-format sort includes.

Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG=688155
TBR=brettw

Review-Url: https://codereview.chromium.org/2669263003
Cr-Commit-Position: refs/heads/master@{#447875}
Committed: https://chromium.googlesource.com/chromium/src/+/6b08b5d1106a7faa33f2dbb8c07ac9ba67058e16

[Nico, 2017-02-02 22:39:51]

Description was changed from

==========
Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

BUG=688155
==========

to

==========
Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG=688155
==========

[Nico, 2017-02-02 22:40:00]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 22:40:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-02 22:41:17]

thakis@chromium.org changed reviewers:
+ sky@chromium.org

[Nico, 2017-02-02 22:41:18]

See CL description for tradeoffs. If we land this (I think we should), I'll send
a note to chromium-dev and blink-dev that this is now on and that people should
send feedback on how it goes. In 4 weeks or so we can then look at feedback and
decide if we want to keep it on (hopefully everyone will just like it and it
won't cause issues).

[sky, 2017-02-02 22:43:40]

That was fast. LGTM!

[commit-bot: I haz the power, 2017-02-02 22:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:50:55]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-02 23:19:57]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-02 23:25:42]

Description was changed from

==========
Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG=688155
==========

to

==========
Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG=688155
TBR=brettw
==========

[Nico, 2017-02-02 23:26:07]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2017-02-02 23:26:08]

tbr brettw for toplevel owners. I should probably make myself and dcheng
per-file owners of .clang-format

[commit-bot: I haz the power, 2017-02-02 23:31:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486077597255910, "parent_rev":
"9b2a0b1bc7034aa17ede1914e0620d3f71fe8dec", "commit_rev":
"6b08b5d1106a7faa33f2dbb8c07ac9ba67058e16"}

[commit-bot: I haz the power, 2017-02-02 23:35:12]

Description was changed from

==========
Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG=688155
TBR=brettw
==========

to

==========
Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG=688155
TBR=brettw

Review-Url: https://codereview.chromium.org/2669263003
Cr-Commit-Position: refs/heads/master@{#447875}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b08b5d1106a7faa33f2dbb8c07a...
==========

[commit-bot: I haz the power, 2017-02-02 23:35:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b08b5d1106a7faa33f2dbb8c07a...