Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2669243007: [Downloads] Use content:// URIs in more places (Closed)

Created:
3 years, 10 months ago by gone
Modified:
3 years, 10 months ago
Reviewers:
Theresa, Yusuf, qinmin
CC:
chromium-reviews, asanka, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Downloads] Use content:// URIs in more places * Use content:// URIs in more places instead of file:// URIs. This avoids problems with Android N+ complaining about passing around file:// URIs. * Allow Intents for Media Viewer Custom Tabs to have an additional URI that can override the one passed along via the Intent's data. The file:// URI is necessary to deal with Custom Tabs displaying "content:" and a database ID instead of the filename and its location. BUG=658012 TBR=qinmin,twellington,yusufo Original-Review-Url: https://codereview.chromium.org/2671573002 Original-Cr-Commit-Position: refs/heads/master@{#447821} Review-Url: https://codereview.chromium.org/2669243007 . Cr-Commit-Position: refs/branch-heads/2987@{#285} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d9e65e42e3965f2b86054c35c381588f6a339403

Patch Set 1 #

Patch Set 2 : Matching #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java View 5 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
gone
3 years, 10 months ago (2017-02-02 23:05:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d9e65e42e3965f2b86054c35c381588f6a339403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698