[Test] Reconfigure SuperSpread benchmarks to run in separate processes.

[Test] Reconfigure SuperSpread benchmarks to run in separate processes.

BUG=v8:5922
Review-Url: https://codereview.chromium.org/2669223002
Cr-Commit-Position: refs/heads/master@{#42929}
Committed: https://chromium.googlesource.com/v8/v8/+/98ca77a0e1cc676ad9bfff663d5fcfe734f9843a

[petermarshall, 2017-02-02 14:26:26]

Description was changed from

==========
[Test] Reconfigure SuperSpread benchmarks to run in separate processes

BUG=v8:5922
==========

to

==========
[Test] Reconfigure SuperSpread benchmarks to run in separate processes.

BUG=v8:5922
==========

[Michael Achenbach, 2017-02-02 14:50:19]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-02-02 14:50:19]

https://codereview.chromium.org/2669223002/diff/1/test/js-perf-test/SixSpeed....
File test/js-perf-test/SixSpeed.json (right):

https://codereview.chromium.org/2669223002/diff/1/test/js-perf-test/SixSpeed....
test/js-perf-test/SixSpeed.json:58: "results_regexp": "^%s\\(Score\\): (.+)$",
Did you check locally that this works? It can be that the regexp needs to move a
level lower with the %s replaced with the actual name.

https://codereview.chromium.org/2669223002/diff/1/test/js-perf-test/SixSpeed....
test/js-perf-test/SixSpeed.json:61: "name": "ES5",
You could also reuse the same run.js and pass a different flag to it for each
benchmark. You can use the test_flags key for that.

[petermarshall, 2017-02-03 09:54:35]

https://codereview.chromium.org/2669223002/diff/1/test/js-perf-test/SixSpeed....
File test/js-perf-test/SixSpeed.json (right):

https://codereview.chromium.org/2669223002/diff/1/test/js-perf-test/SixSpeed....
test/js-perf-test/SixSpeed.json:58: "results_regexp": "^%s\\(Score\\): (.+)$",
On 2017/02/02 at 14:50:19, Michael Achenbach wrote:
> Did you check locally that this works? It can be that the regexp needs to move
a level lower with the %s replaced with the actual name.

Yes it runs locally and produces the correct JSON.

https://codereview.chromium.org/2669223002/diff/1/test/js-perf-test/SixSpeed....
test/js-perf-test/SixSpeed.json:61: "name": "ES5",
On 2017/02/02 at 14:50:19, Michael Achenbach wrote:
> You could also reuse the same run.js and pass a different flag to it for each
benchmark. You can use the test_flags key for that.

That is awesome, I was wondering if there was something like that. Done!

[Michael Achenbach, 2017-02-03 12:34:14]

lgtm

https://codereview.chromium.org/2669223002/diff/20001/test/js-perf-test/SixSp...
File test/js-perf-test/SixSpeed.json (right):

https://codereview.chromium.org/2669223002/diff/20001/test/js-perf-test/SixSp...
test/js-perf-test/SixSpeed.json:61: "name": "ES5",
You could consider landing this CL while keeping the old names and rename in a
different CL. Like that you'd see the effects in the same graph.

Or maybe that's exactly what you don't want - if you rename in this CL you get a
clean cut and new graphs...

[petermarshall, 2017-02-03 13:33:22]

On 2017/02/03 at 12:34:14, machenbach wrote:
> lgtm
> 
>
https://codereview.chromium.org/2669223002/diff/20001/test/js-perf-test/SixSp...
> File test/js-perf-test/SixSpeed.json (right):
> 
>
https://codereview.chromium.org/2669223002/diff/20001/test/js-perf-test/SixSp...
> test/js-perf-test/SixSpeed.json:61: "name": "ES5",
> You could consider landing this CL while keeping the old names and rename in a
different CL. Like that you'd see the effects in the same graph.
> 
> Or maybe that's exactly what you don't want - if you rename in this CL you get
a clean cut and new graphs...

Thanks, good point. I think new graphs would be nice, because the new data won't
be comparable to the old data anyway.

[petermarshall, 2017-02-03 13:33:35]

The CQ bit was checked by petermarshall@chromium.org

[commit-bot: I haz the power, 2017-02-03 13:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 14:07:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486128815946380,
"parent_rev": "c21d1281d9a0c9db39441d798ff04d164d76259f", "commit_rev":
"98ca77a0e1cc676ad9bfff663d5fcfe734f9843a"}

[commit-bot: I haz the power, 2017-02-03 14:07:21]

Description was changed from

==========
[Test] Reconfigure SuperSpread benchmarks to run in separate processes.

BUG=v8:5922
==========

to

==========
[Test] Reconfigure SuperSpread benchmarks to run in separate processes.

BUG=v8:5922

Review-Url: https://codereview.chromium.org/2669223002
Cr-Commit-Position: refs/heads/master@{#42929}
Committed:
https://chromium.googlesource.com/v8/v8/+/98ca77a0e1cc676ad9bfff663d5fcfe734f...
==========

[commit-bot: I haz the power, 2017-02-03 14:07:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/98ca77a0e1cc676ad9bfff663d5fcfe734f...