Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2669213004: Removed cc::CompositorFrameSink::client_thread_checker_ (Closed)

Created:
3 years, 10 months ago by Alex Z.
Modified:
3 years, 10 months ago
Reviewers:
danakj, jbauman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cc-bugs_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, xlai (Olivia)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed cc::CompositorFrameSink::client_thread_checker_ RendererCompositorFrameSink holds its own thread checker similar to what WindowCompositorFrameSink and DirectCompositorFrameSink do. This way, cc::CompositorFrameSink::client_thread_check_ is no longer needed and we have one less field in the API class. BUG=673543 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2669213004 Cr-Commit-Position: refs/heads/master@{#447941} Committed: https://chromium.googlesource.com/chromium/src/+/6ef62be33d4c2fcc79b6046e8b1a6fd9a1c50093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M cc/output/compositor_frame_sink.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/compositor_frame_sink.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Alex Z.
danakj@: please review changes in compositor_frame_sink.* jbauman@: please review changes in renderer_compositor_frame_sink.*
3 years, 10 months ago (2017-02-02 21:13:55 UTC) #7
danakj
LGTM
3 years, 10 months ago (2017-02-02 21:16:17 UTC) #8
jbauman
lgtm
3 years, 10 months ago (2017-02-03 03:07:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669213004/1
3 years, 10 months ago (2017-02-03 04:43:53 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:50:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ef62be33d4c2fcc79b6046e8b1a...

Powered by Google App Engine
This is Rietveld 408576698