Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2669203006: When restoring kiosk app after crash, skip app installation steps. Installed apps should already be… (Closed)

Created:
3 years, 10 months ago by tbarzic
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

When restoring kiosk app after crash, skip app installation steps. Installed apps should already be restored as part of starting crash recovery session. During crash recovery, StartupAppLauncher::Delegate always reports network as ready, so it cannot be determined whether the network is truly available - if it's not update checks will take ~30 minutes to fail, during which there will be no UI shown (as there is no login UI in this case). Additionally, it would be unexpected for the app to recover to updated version after a Chroem crash. BUG=686846 Review-Url: https://codereview.chromium.org/2662113002 Cr-Commit-Position: refs/heads/master@{#447127} (cherry picked from commit 6394703fb6ccb291ae4afce516471a1b6d76c3db) Review-Url: https://codereview.chromium.org/2669203006 . Cr-Commit-Position: refs/branch-heads/2987@{#292} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8af9a09dc382e5f55e3b583aa2d558196c228c71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M chrome/browser/chromeos/app_mode/app_launch_utils.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 3 chunks +30 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbarzic
3 years, 10 months ago (2017-02-03 18:16:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8af9a09dc382e5f55e3b583aa2d558196c228c71.

Powered by Google App Engine
This is Rietveld 408576698