Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 2669173002: Use IOSImageDataFetcherWrapper (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, jdonnelly+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IOSImageDataFetcherWrapper Uses IOSImageDataFetcherWrapper in components instead of ImageDataFetcher in ios/web/public. BUG=683918 Review-Url: https://codereview.chromium.org/2669173002 Cr-Commit-Position: refs/heads/master@{#451016} Committed: https://chromium.googlesource.com/chromium/src/+/3b4fcbd5a15588d9823c4d85b7030fc2669882e6

Patch Set 1 #

Patch Set 2 : Update comments #

Total comments: 2

Patch Set 3 : Remove unnecessary functions #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Messages

Total messages: 35 (21 generated)
gambard
PTAL. Downstream CL: https://chromereviews.googleplex.com/569887014 https://codereview.chromium.org/2669173002/diff/20001/ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h File ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h (left): https://codereview.chromium.org/2669173002/diff/20001/ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h#oldcode63 ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h:63: - (void)fetchSmallIconWithContext:(net::URLRequestContextGetter*)contextGetter Kept for downstream ...
3 years, 10 months ago (2017-02-02 10:34:07 UTC) #2
gambard
This CL will land after the downstream CL. https://codereview.chromium.org/2669173002/diff/20001/ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h File ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h (left): https://codereview.chromium.org/2669173002/diff/20001/ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h#oldcode63 ios/public/provider/chrome/browser/native_app_launcher/native_app_metadata.h:63: - ...
3 years, 10 months ago (2017-02-02 10:46:02 UTC) #3
gambard
Be also aware that this new ImageDataFetcher does not set flags where the old one ...
3 years, 10 months ago (2017-02-02 13:46:34 UTC) #8
gambard
ping
3 years, 10 months ago (2017-02-09 14:31:13 UTC) #9
rohitrao (ping after 24h)
What is the motivation for this change? What's wrong with the existing fetcher in //web? ...
3 years, 10 months ago (2017-02-09 14:52:59 UTC) #10
gambard
On 2017/02/09 14:52:59, rohitrao wrote: > What is the motivation for this change? What's wrong ...
3 years, 10 months ago (2017-02-09 15:17:45 UTC) #11
gambard
+eugene, kurt. Do you have any answer for the flags/referrer question asked by rohit? Thanks!
3 years, 10 months ago (2017-02-13 09:27:24 UTC) #13
Eugene But (OOO till 7-30)
On 2017/02/13 09:27:24, gambard wrote: > +eugene, kurt. > Do you have any answer for ...
3 years, 10 months ago (2017-02-13 17:45:02 UTC) #14
rohitrao (ping after 24h)
lgtm Please convince yourself that the flag changes are unimportant before landing =)
3 years, 10 months ago (2017-02-14 12:38:08 UTC) #15
gambard
I did not see any change ;) Kurt, do you have an opinion on this?
3 years, 10 months ago (2017-02-14 14:10:36 UTC) #16
kkhorimoto
On 2017/02/14 14:10:36, gambard wrote: > I did not see any change ;) > Kurt, ...
3 years, 10 months ago (2017-02-14 17:39:34 UTC) #17
gambard
Thanks, I am landing this.
3 years, 10 months ago (2017-02-16 16:27:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669173002/80001
3 years, 10 months ago (2017-02-16 17:44:35 UTC) #32
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 18:35:13 UTC) #35
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3b4fcbd5a15588d9823c4d85b703...

Powered by Google App Engine
This is Rietveld 408576698