[parser] Skipping inner funcs: produce the same scopes / variables for (some) loops.

[parser] Skipping inner funcs: produce the same scopes / variables for (some) loops.

Turns out is_hidden is not the right condition for "scope should be present in
the preparse data". For now, replaced it with "is hidden leaf scope" (i.e.,
doesn't contain any non-hidden scopes). That's probably not the right condition
either; will be fixed once there's more data to decide what the right condition
is.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2669163002
Cr-Commit-Position: refs/heads/master@{#42909}
Committed: https://chromium.googlesource.com/v8/v8/+/b04d1d0ec6de2396e98b0bfa3db320c90e6410dd

[marja, 2017-02-02 10:09:40]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 10:09:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-02-02 10:12:51]

vogelheim@, ptal
verwaest@, adamk@, fyi

[marja, 2017-02-02 10:14:10]

Description was changed from

==========
[parser] Skipping inner funcs: produce the same scopes / variables for (some)
loops.

- Turns out is_hidden is not the right condition for "scope should be
  present in the preparse data". For now, replaced it with "is hidden
  leaf scope" (i.e., doesn't contain any non-hidden scopes). That's
  probably not the right condition either; will be fixed in an upcoming
  CL.

BUG=v8:5516
R=vogelheim@chromium.org
==========

to

==========
[parser] Skipping inner funcs: produce the same scopes / variables for (some)
loops.

Turns out is_hidden is not the right condition for "scope should be present in
the preparse data". For now, replaced it with "is hidden leaf scope" (i.e.,
doesn't contain any non-hidden scopes). That's probably not the right condition
either; will be fixed once there's more data to decide what the right condition
is.

BUG=v8:5516
R=vogelheim@chromium.org
==========

[commit-bot: I haz the power, 2017-02-02 10:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 10:35:56]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2017-02-02 18:28:56]

lgtm

https://codereview.chromium.org/2669163002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2669163002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8838: // True if the scope is hidden and all scopes
in its subscope tree are hidden
super nitpick:
 // True if this scope and its entire subscope tree are hidden.

Fits in one line. :)

https://codereview.chromium.org/2669163002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8840: static bool IsHiddenLeafScope(Scope* scope) {
naming nitpick: I'm not super happy with the name, since the scope for which
this is called isn't really a leaf scope. Maybe: AllInnerScopesAreHidden? Or
ScopeTreeIsHidden? Or ContainsVisibleScope (then with reversed return value)?

[marja, 2017-02-03 06:48:59]

thanks for review!

https://codereview.chromium.org/2669163002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2669163002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8838: // True if the scope is hidden and all scopes
in its subscope tree are hidden
On 2017/02/02 18:28:56, vogelheim wrote:
> super nitpick:
>  // True if this scope and its entire subscope tree are hidden.
> 
> Fits in one line. :)

Done.

https://codereview.chromium.org/2669163002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8840: static bool IsHiddenLeafScope(Scope* scope) {
On 2017/02/02 18:28:56, vogelheim wrote:
> naming nitpick: I'm not super happy with the name, since the scope for which
> this is called isn't really a leaf scope. Maybe: AllInnerScopesAreHidden? Or
> ScopeTreeIsHidden? Or ContainsVisibleScope (then with reversed return value)?

Done.

[marja, 2017-02-03 06:49:25]

The CQ bit was checked by marja@chromium.org

[marja, 2017-02-03 06:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2669163002/#ps20001
(title: "code review (vogelheim@)")

[commit-bot: I haz the power, 2017-02-03 06:49:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 07:14:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486104565826970,
"parent_rev": "45721b712e7179918cd79a3c8d7a6c5d1bd9adc7", "commit_rev":
"b04d1d0ec6de2396e98b0bfa3db320c90e6410dd"}

[commit-bot: I haz the power, 2017-02-03 07:14:54]

Description was changed from

==========
[parser] Skipping inner funcs: produce the same scopes / variables for (some)
loops.

Turns out is_hidden is not the right condition for "scope should be present in
the preparse data". For now, replaced it with "is hidden leaf scope" (i.e.,
doesn't contain any non-hidden scopes). That's probably not the right condition
either; will be fixed once there's more data to decide what the right condition
is.

BUG=v8:5516
R=vogelheim@chromium.org
==========

to

==========
[parser] Skipping inner funcs: produce the same scopes / variables for (some)
loops.

Turns out is_hidden is not the right condition for "scope should be present in
the preparse data". For now, replaced it with "is hidden leaf scope" (i.e.,
doesn't contain any non-hidden scopes). That's probably not the right condition
either; will be fixed once there's more data to decide what the right condition
is.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2669163002
Cr-Commit-Position: refs/heads/master@{#42909}
Committed:
https://chromium.googlesource.com/v8/v8/+/b04d1d0ec6de2396e98b0bfa3db320c90e6...
==========

[commit-bot: I haz the power, 2017-02-03 07:14:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b04d1d0ec6de2396e98b0bfa3db320c90e6...