Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2669153002: [scopes] With --print-scopes, print is_hidden() status too. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[scopes] With --print-scopes, print is_hidden() status too. BUG=v8:5516 R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2669153002 Cr-Commit-Position: refs/heads/master@{#42899} Committed: https://chromium.googlesource.com/v8/v8/+/dbda66ec4f7f26b7870ebc0b7b5d348573d7b9aa

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/ast/scopes.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
marja
ptal
3 years, 10 months ago (2017-02-02 10:11:31 UTC) #6
vogelheim
lgtm
3 years, 10 months ago (2017-02-02 18:06:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669153002/20001
3 years, 10 months ago (2017-02-02 19:36:18 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 20:01:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/dbda66ec4f7f26b7870ebc0b7b5d348573d...

Powered by Google App Engine
This is Rietveld 408576698