Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2669093002: DevTools: migrate the closeButton icons over to UI.Icon (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate the closeButton icons over to UI.Icon This patch migrates closeButton over to the UI.Icon. CloseButton could be found in a few places, e.g. in the TabbedPane tab and in the network's panel request view. BUG=669323 R=dgozman_slow Review-Url: https://codereview.chromium.org/2669093002 Cr-Commit-Position: refs/heads/master@{#447707} Committed: https://chromium.googlesource.com/chromium/src/+/7aee106060efcc49f9768365b77f1ea697b17230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/closeButton.css View 1 chunk +13 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lushnikov
This patch migrates the last occurrence of toolbarButtonGlyphs to the UI.Icon. Yay! please, take a ...
3 years, 10 months ago (2017-02-02 02:25:17 UTC) #1
dgozman
On 2017/02/02 02:25:17, lushnikov wrote: > This patch migrates the last occurrence of toolbarButtonGlyphs to ...
3 years, 10 months ago (2017-02-02 04:06:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669093002/1
3 years, 10 months ago (2017-02-02 05:05:27 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:21:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7aee106060efcc49f9768365b77f...

Powered by Google App Engine
This is Rietveld 408576698