Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2669053004: Remove mixed-source.patch from zlib. (Closed)

Created:
3 years, 10 months ago by davidben
Modified:
3 years, 10 months ago
Reviewers:
Bence, agl
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mixed-source.patch from zlib. With SPDY gone, this is no longer necessary. This change was done by reversing simd.patch, reversing mixed-source.patch, reapplying simd.patch, and then recreating simd.patch. BUG=none Review-Url: https://codereview.chromium.org/2669053004 Cr-Commit-Position: refs/heads/master@{#447853} Committed: https://chromium.googlesource.com/chromium/src/+/f2095b9da969dd7decf3224fc96ffe8ef5f5455b

Patch Set 1 #

Patch Set 2 : delete mixed-source.patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -807 lines) Patch
M third_party/zlib/README.chromium View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/zlib/deflate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/zlib/deflate.c View 20 chunks +28 lines, -226 lines 0 comments Download
D third_party/zlib/mixed-source.patch View 1 1 chunk +0 lines, -498 lines 0 comments Download
M third_party/zlib/simd.patch View 28 chunks +54 lines, -62 lines 0 comments Download
M third_party/zlib/zlib.h View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
davidben
agl and bnc: Is there any reason we still need to keep this around? (Also, ...
3 years, 10 months ago (2017-02-02 19:24:23 UTC) #6
Bence
LGTM, thank you.
3 years, 10 months ago (2017-02-02 19:33:03 UTC) #7
agl
LGTM. Thank god that thing is dead.
3 years, 10 months ago (2017-02-02 19:36:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669053004/20001
3 years, 10 months ago (2017-02-02 19:37:35 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 21:59:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2095b9da969dd7decf3224fc96f...

Powered by Google App Engine
This is Rietveld 408576698