MD Settings: Remove remaining importHtml() calls from site settings tests.

MD Settings: Remove remaining importHtml() calls from site settings tests.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2669033008
Cr-Commit-Position: refs/heads/master@{#447905}
Committed: https://chromium.googlesource.com/chromium/src/+/b69c81cc077bc63f12c61a46528dff5ce22e9985

[dpapad, 2017-02-02 23:44:34]

Description was changed from

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the enableSiteSettings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
==========

to

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the enableSiteSettings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-02 23:44:37]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-02-02 23:45:16]

Description was changed from

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the enableSiteSettings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-02 23:45:25]

Description was changed from

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-02-02 23:45:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-02 23:47:42]

Description was changed from

==========
MD Settings: Remove remaining importHtml() calls from site settings test.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remaining importHtml() calls from site settings tests.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-02 23:57:49]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2017-02-02 23:57:50]

https://codereview.chromium.org/2669033008/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/site_details_permission_tests.js (left):

https://codereview.chromium.org/2669033008/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/site_details_permission_tests.js:49: return
PolymerTest.importHtml(
These are not needed anymore, since the parent test is using privacy_page.html
as the browserPreload value, which already pulls in those dependencies.

[commit-bot: I haz the power, 2017-02-03 01:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:01:11]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-03 01:34:04]

lgtm

[dpapad, 2017-02-03 01:40:00]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:40:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 03:36:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486086000380360, "parent_rev":
"1b48ba269c836ccff3c6f9cc76210f04d791e824", "commit_rev":
"b69c81cc077bc63f12c61a46528dff5ce22e9985"}

[commit-bot: I haz the power, 2017-02-03 03:37:23]

Description was changed from

==========
MD Settings: Remove remaining importHtml() calls from site settings tests.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remaining importHtml() calls from site settings tests.

This fixes site-details related tests in Vulcanized mode as well as the site
details view when the --enable-site-settings runtime flag is supplied.

When in Vulcanized mode, the tests can no longer include site_details.html
directly, since all URLs redirect to the top-level doc. <site-details> was not
imported anywhere from settings.html's transitive deps, making it impossible for
the tests to pass in Vulcanized mode.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2669033008
Cr-Commit-Position: refs/heads/master@{#447905}
Committed:
https://chromium.googlesource.com/chromium/src/+/b69c81cc077bc63f12c61a46528d...
==========

[commit-bot: I haz the power, 2017-02-03 03:37:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b69c81cc077bc63f12c61a46528d...