Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2669023002: Convert WebContentsModalDialogManager to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Mike Wittman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert WebContentsModalDialogManager to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2669023002 Cr-Commit-Position: refs/heads/master@{#448411} Committed: https://chromium.googlesource.com/chromium/src/+/0ae0eec436b87d4a1a773fe5a8ac9104642ed01e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M components/web_modal/web_contents_modal_dialog_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-02-06 20:39:44 UTC) #5
Mike Wittman
lgtm
3 years, 10 months ago (2017-02-06 22:00:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669023002/1
3 years, 10 months ago (2017-02-06 22:08:09 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:17:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ae0eec436b87d4a1a773fe5a8ac...

Powered by Google App Engine
This is Rietveld 408576698