Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: components/resources/ntp_tiles_resources.grdp

Issue 2668943002: provide static popular sites for first run (Closed)
Patch Set: Move default site definition into resource file Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/resources/ntp_tiles_resources.grdp
diff --git a/components/resources/ntp_tiles_resources.grdp b/components/resources/ntp_tiles_resources.grdp
index 37999984ffcbec0863d51826cc1cc374c224185f..e385fb37a2824fa742acf1ad61d9bebb04f2de76 100644
--- a/components/resources/ntp_tiles_resources.grdp
+++ b/components/resources/ntp_tiles_resources.grdp
@@ -5,6 +5,7 @@
<include name="IDR_POPULAR_SITES_INTERNALS_JS" file="../ntp_tiles/webui/resources/popular_sites_internals.js" type="BINDATA" />
<include name="IDR_POPULAR_SITES_INTERNALS_CSS" file="../ntp_tiles/webui/resources/popular_sites_internals.css" type="BINDATA" />
</if>
+ <include name="IDR_DEFAULT_POPULAR_SITES_JSON" file="../ntp_tiles/resources/default_popular_sites.json" type="BINDATA" />
sfiera 2017/02/09 12:39:06 Inside the android/ios block.
fhorschig 2017/02/09 15:30:18 It used to be there. I would prefer it outside. Th
sfiera 2017/02/10 10:40:03 I would rather restrict the unit test to android/i
fhorschig 2017/02/13 10:34:12 Done. The unittest checks the number of tiles for
<include name="IDR_NTP_TILES_INTERNALS_HTML" file="../ntp_tiles/webui/resources/ntp_tiles_internals.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />
<include name="IDR_NTP_TILES_INTERNALS_JS" file="../ntp_tiles/webui/resources/ntp_tiles_internals.js" type="BINDATA" />
<include name="IDR_NTP_TILES_INTERNALS_CSS" file="../ntp_tiles/webui/resources/ntp_tiles_internals.css" type="BINDATA" />

Powered by Google App Engine
This is Rietveld 408576698