components/resources/ntp_tiles_resources.grdp - Issue 2668943002: provide static popular sites for first run

Side by Side Diff: components/resources/ntp_tiles_resources.grdp

Issue 2668943002: provide static popular sites for first run (Closed)

Patch Set: Move default site definition into resource file Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <if expr="is_android or is_ios">	3 <if expr="is_android or is_ios">

4 <include name="IDR_POPULAR_SITES_INTERNALS_HTML" file="../ntp_tiles/webui/re sources/popular_sites_internals.html" flattenhtml="true" allowexternalscript="tr ue" type="BINDATA" />	4 <include name="IDR_POPULAR_SITES_INTERNALS_HTML" file="../ntp_tiles/webui/re sources/popular_sites_internals.html" flattenhtml="true" allowexternalscript="tr ue" type="BINDATA" />

5 <include name="IDR_POPULAR_SITES_INTERNALS_JS" file="../ntp_tiles/webui/reso urces/popular_sites_internals.js" type="BINDATA" />	5 <include name="IDR_POPULAR_SITES_INTERNALS_JS" file="../ntp_tiles/webui/reso urces/popular_sites_internals.js" type="BINDATA" />

6 <include name="IDR_POPULAR_SITES_INTERNALS_CSS" file="../ntp_tiles/webui/res ources/popular_sites_internals.css" type="BINDATA" />	6 <include name="IDR_POPULAR_SITES_INTERNALS_CSS" file="../ntp_tiles/webui/res ources/popular_sites_internals.css" type="BINDATA" />

7 </if>	7 </if>

	8 <include name="IDR_DEFAULT_POPULAR_SITES_JSON" file="../ntp_tiles/resources/de fault_popular_sites.json" type="BINDATA" />
	sfiera 2017/02/09 12:39:06 Inside the android/ios block. Inside the android/ios block. fhorschig 2017/02/09 15:30:18 It used to be there. I would prefer it outside. Th Show quoted text On 2017/02/09 12:39:06, sfiera wrote: > Inside the android/ios block. It used to be there. I would prefer it outside. That way, component_unittests can easily verify the contents of this file. sfiera 2017/02/10 10:40:03 I would rather restrict the unit test to android/i Show quoted text On 2017/02/09 15:30:18, fhorschig wrote: > On 2017/02/09 12:39:06, sfiera wrote: > > Inside the android/ios block. > > It used to be there. I would prefer it outside. > That way, component_unittests can easily verify the contents of this file. I would rather restrict the unit test to android/ios, but you're welcome to get a second opinion. fhorschig 2017/02/13 10:34:12 Done. The unittest checks the number of tiles for Show quoted text On 2017/02/10 10:40:03, sfiera wrote: > On 2017/02/09 15:30:18, fhorschig wrote: > > On 2017/02/09 12:39:06, sfiera wrote: > > > Inside the android/ios block. > > > > It used to be there. I would prefer it outside. > > That way, component_unittests can easily verify the contents of this file. > > I would rather restrict the unit test to android/ios, but you're welcome to get > a second opinion. Done. The unittest checks the number of tiles for mobile only.
8 <include name="IDR_NTP_TILES_INTERNALS_HTML" file="../ntp_tiles/webui/resource s/ntp_tiles_internals.html" flattenhtml="true" allowexternalscript="true" type=" BINDATA" />	9 <include name="IDR_NTP_TILES_INTERNALS_HTML" file="../ntp_tiles/webui/resource s/ntp_tiles_internals.html" flattenhtml="true" allowexternalscript="true" type=" BINDATA" />

9 <include name="IDR_NTP_TILES_INTERNALS_JS" file="../ntp_tiles/webui/resources/ ntp_tiles_internals.js" type="BINDATA" />	10 <include name="IDR_NTP_TILES_INTERNALS_JS" file="../ntp_tiles/webui/resources/ ntp_tiles_internals.js" type="BINDATA" />

10 <include name="IDR_NTP_TILES_INTERNALS_CSS" file="../ntp_tiles/webui/resources /ntp_tiles_internals.css" type="BINDATA" />	11 <include name="IDR_NTP_TILES_INTERNALS_CSS" file="../ntp_tiles/webui/resources /ntp_tiles_internals.css" type="BINDATA" />

11 </grit-part>	12 </grit-part>

OLD	NEW

« components/ntp_tiles/resources/default_popular_sites.json ('K') | « components/ntp_tiles/resources/default_popular_sites.json ('k') | no next file » | no next file with comments »