Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2668933003: Fix Reading List Collection View Controller (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Reading List Collection View Controller This CL fixes the test to see if a new entry was added to the ReadingListModel. BUG=687613 Review-Url: https://codereview.chromium.org/2668933003 Cr-Commit-Position: refs/heads/master@{#447546} Committed: https://chromium.googlesource.com/chromium/src/+/6e0361b43828f6ed6f6b31e451bf2573a5dd012a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
gambard
PTAL.
3 years, 10 months ago (2017-02-01 15:29:33 UTC) #2
Olivier
lgtm Can you put in comment the CL it is fixing ? And add the ...
3 years, 10 months ago (2017-02-01 15:30:39 UTC) #3
gambard
Thanks! Description updated.
3 years, 10 months ago (2017-02-01 16:49:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668933003/1
3 years, 10 months ago (2017-02-01 16:49:26 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 17:17:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e0361b43828f6ed6f6b31e451bf...

Powered by Google App Engine
This is Rietveld 408576698