Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2668933002: Revert of [turbofan] Constant propagation for JumpIfFalse/JumpIfTrue. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Constant propagation for JumpIfFalse/JumpIfTrue. (patchset #4 id:60001 of https://codereview.chromium.org/2666283002/ ) Reason for revert: Breaks win64 it seems. Original issue's description: > [turbofan] Constant propagation for JumpIfFalse/JumpIfTrue. > > The JumpIfFalse and JumpIfTrue bytecodes test the accumulator, and > branch based on whether the accumulator is true or false (no other > value allowed, and in fact TurboFan would blow up if you would pass > anything else, since Branch operator can only deal with Boolean). > So for either branch we know exactly the value of the accumulator, > and we can update the environment to this constant value instead. > > This helps to avoid the useless bit materialization that currently > happens when || or && is being used in a value context. > > R=jarin@chromium.org > BUG=v8:5267 > > Review-Url: https://codereview.chromium.org/2666283002 > Cr-Commit-Position: refs/heads/master@{#42843} > Committed: https://chromium.googlesource.com/v8/v8/+/158ac9287193f315342ad31c38fe451620d176eb TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5267 Review-Url: https://codereview.chromium.org/2668933002 Cr-Commit-Position: refs/heads/master@{#42845} Committed: https://chromium.googlesource.com/v8/v8/+/d369c4dc47a161663e2c442e2f81ab0c0d363914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -43 lines) Patch
M src/code-stub-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +2 lines, -16 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +4 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [turbofan] Constant propagation for JumpIfFalse/JumpIfTrue.
3 years, 10 months ago (2017-02-01 10:35:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668933002/1
3 years, 10 months ago (2017-02-01 10:36:04 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 10:37:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d369c4dc47a161663e2c442e2f81ab0c0d3...

Powered by Google App Engine
This is Rietveld 408576698