Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp
diff --git a/third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp b/third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp
index 07eb73ca7b949c5e99e4c05d92a68b43460f5598..acaee22832dc68df09c65aaccf64cc91a6736560 100644
--- a/third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp
+++ b/third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp
@@ -286,7 +286,7 @@ TEST(StringBuilderTest, ToAtomicStringOnEmpty) {
}
{ // AtomicString constructed from an empty string.
StringBuilder builder;
- builder.append(emptyString());
+ builder.append(emptyString);
AtomicString atomicString = builder.toAtomicString();
EXPECT_EQ(emptyAtom, atomicString);
}
@@ -316,7 +316,7 @@ TEST(StringBuilderTest, Substring) {
{ // Default constructed.
StringBuilder builder;
String substring = builder.substring(0, 10);
- EXPECT_EQ(emptyString(), substring);
+ EXPECT_EQ(emptyString, substring);
}
{ // With capacity.
StringBuilder builder;
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringBuilder.cpp ('k') | third_party/WebKit/Source/wtf/text/StringStatics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698