Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 EXPECT_EQ(emptyAtom, atomicString); 279 EXPECT_EQ(emptyAtom, atomicString);
280 } 280 }
281 { // AtomicString constructed from a null string. 281 { // AtomicString constructed from a null string.
282 StringBuilder builder; 282 StringBuilder builder;
283 builder.append(String()); 283 builder.append(String());
284 AtomicString atomicString = builder.toAtomicString(); 284 AtomicString atomicString = builder.toAtomicString();
285 EXPECT_EQ(emptyAtom, atomicString); 285 EXPECT_EQ(emptyAtom, atomicString);
286 } 286 }
287 { // AtomicString constructed from an empty string. 287 { // AtomicString constructed from an empty string.
288 StringBuilder builder; 288 StringBuilder builder;
289 builder.append(emptyString()); 289 builder.append(emptyString);
290 AtomicString atomicString = builder.toAtomicString(); 290 AtomicString atomicString = builder.toAtomicString();
291 EXPECT_EQ(emptyAtom, atomicString); 291 EXPECT_EQ(emptyAtom, atomicString);
292 } 292 }
293 { // AtomicString constructed from an empty StringBuilder. 293 { // AtomicString constructed from an empty StringBuilder.
294 StringBuilder builder; 294 StringBuilder builder;
295 StringBuilder emptyBuilder; 295 StringBuilder emptyBuilder;
296 builder.append(emptyBuilder); 296 builder.append(emptyBuilder);
297 AtomicString atomicString = builder.toAtomicString(); 297 AtomicString atomicString = builder.toAtomicString();
298 EXPECT_EQ(emptyAtom, atomicString); 298 EXPECT_EQ(emptyAtom, atomicString);
299 } 299 }
300 { // AtomicString constructed from an empty char* string. 300 { // AtomicString constructed from an empty char* string.
301 StringBuilder builder; 301 StringBuilder builder;
302 builder.append("", 0); 302 builder.append("", 0);
303 AtomicString atomicString = builder.toAtomicString(); 303 AtomicString atomicString = builder.toAtomicString();
304 EXPECT_EQ(emptyAtom, atomicString); 304 EXPECT_EQ(emptyAtom, atomicString);
305 } 305 }
306 { // Cleared StringBuilder. 306 { // Cleared StringBuilder.
307 StringBuilder builder; 307 StringBuilder builder;
308 builder.append("WebKit"); 308 builder.append("WebKit");
309 builder.clear(); 309 builder.clear();
310 AtomicString atomicString = builder.toAtomicString(); 310 AtomicString atomicString = builder.toAtomicString();
311 EXPECT_EQ(emptyAtom, atomicString); 311 EXPECT_EQ(emptyAtom, atomicString);
312 } 312 }
313 } 313 }
314 314
315 TEST(StringBuilderTest, Substring) { 315 TEST(StringBuilderTest, Substring) {
316 { // Default constructed. 316 { // Default constructed.
317 StringBuilder builder; 317 StringBuilder builder;
318 String substring = builder.substring(0, 10); 318 String substring = builder.substring(0, 10);
319 EXPECT_EQ(emptyString(), substring); 319 EXPECT_EQ(emptyString, substring);
320 } 320 }
321 { // With capacity. 321 { // With capacity.
322 StringBuilder builder; 322 StringBuilder builder;
323 builder.reserveCapacity(64); 323 builder.reserveCapacity(64);
324 builder.append("abc"); 324 builder.append("abc");
325 String substring = builder.substring(2, 10); 325 String substring = builder.substring(2, 10);
326 EXPECT_EQ(String("c"), substring); 326 EXPECT_EQ(String("c"), substring);
327 } 327 }
328 } 328 }
329 329
330 TEST(StringBuilderTest, AppendNumberDoubleUChar) { 330 TEST(StringBuilderTest, AppendNumberDoubleUChar) {
331 const double someNumber = 1.2345; 331 const double someNumber = 1.2345;
332 StringBuilder reference; 332 StringBuilder reference;
333 reference.append(replacementCharacter); // Make it UTF-16. 333 reference.append(replacementCharacter); // Make it UTF-16.
334 reference.append(String::number(someNumber)); 334 reference.append(String::number(someNumber));
335 StringBuilder test; 335 StringBuilder test;
336 test.append(replacementCharacter); 336 test.append(replacementCharacter);
337 test.appendNumber(someNumber); 337 test.appendNumber(someNumber);
338 EXPECT_EQ(reference, test); 338 EXPECT_EQ(reference, test);
339 } 339 }
340 340
341 } // namespace WTF 341 } // namespace WTF
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringBuilder.cpp ('k') | third_party/WebKit/Source/wtf/text/StringStatics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698