Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2668893002: [MD Bookmarks] Remove separator lines between list items. (Closed)

Created:
3 years, 10 months ago by angelayang
Modified:
3 years, 10 months ago
Reviewers:
tsergeant, calamity, jiaxi
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Remove separator lines between list items. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2668893002 Cr-Commit-Position: refs/heads/master@{#447654} Committed: https://chromium.googlesource.com/chromium/src/+/d5e23ca635bba70477806fa3ba702a240d398239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/resources/md_bookmarks/item.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_vars.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
angelayang
Hello, this is the cl that removes the separator lines we added previously. thanks
3 years, 10 months ago (2017-02-01 03:02:33 UTC) #3
calamity
lgtm
3 years, 10 months ago (2017-02-01 03:21:24 UTC) #4
tsergeant
lgtm
3 years, 10 months ago (2017-02-01 05:48:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668893002/1
3 years, 10 months ago (2017-02-02 00:17:37 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 00:23:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5e23ca635bba70477806fa3ba70...

Powered by Google App Engine
This is Rietveld 408576698