Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2668873003: [wasm][asm.js] Fix incorrect stack depth in some returns. (Closed)

Created:
3 years, 10 months ago by bradnelson
Modified:
3 years, 10 months ago
Reviewers:
titzer, bradn, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Fix incorrect stack depth in some returns. Previously we allowed unreachable returns to be skipped. This won't work if we strictly follow the spec. BUG=None TEST=Manual against more strict wasm validation R=titzer@chromium.org,rossberg@chromium.org Review-Url: https://codereview.chromium.org/2668873003 Cr-Commit-Position: refs/heads/master@{#42833} Committed: https://chromium.googlesource.com/v8/v8/+/8cee1e7e17a58262b76b7fe48c2318eb2efca609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
bradn
3 years, 10 months ago (2017-02-01 02:58:19 UTC) #4
titzer
lgtm
3 years, 10 months ago (2017-02-01 03:53:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668873003/1
3 years, 10 months ago (2017-02-01 04:02:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 04:04:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8cee1e7e17a58262b76b7fe48c2318eb2ef...

Powered by Google App Engine
This is Rietveld 408576698