Use the CreatePanelLayout() utility method instead of hand-rolling panel layout.

Use the CreatePanelLayout() utility method instead of hand-rolling panel layout.

This is not only shorter, it fixes an issue where the provided insets didn't
make sense.  The expected order of insets is TLBR; the passed insets were
horizontal/vertical/vertical/horizontal, and even if the first two had been
swapped, it would still function differently than other panel layouts.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2668853002
Cr-Commit-Position: refs/heads/master@{#447404}
Committed: https://chromium.googlesource.com/chromium/src/+/2dca6772888dd5454cafc6b50e2ca924fb16b0bd

[Peter Kasting, 2017-01-31 23:39:54]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 23:41:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:55:35]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Peter Kasting, 2017-02-01 00:01:25]

pkasting@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Peter Kasting, 2017-02-01 00:01:25]

I assume this matches the intent, if not the effect, of the original code.

[Peter Kasting, 2017-02-01 00:01:32]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 00:03:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 00:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:52:45]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-02-01 01:30:22]

lgtm

[Peter Kasting, 2017-02-01 01:36:32]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-02-01 01:37:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 01:44:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485912992350320,
"parent_rev": "c7693c792df7d87635d08a5178930279a1fcf7ea", "commit_rev":
"2dca6772888dd5454cafc6b50e2ca924fb16b0bd"}

[commit-bot: I haz the power, 2017-02-01 01:45:28]

Description was changed from

==========
Use the CreatePanelLayout() utility method instead of hand-rolling panel layout.

This is not only shorter, it fixes an issue where the provided insets didn't
make sense.  The expected order of insets is TLBR; the passed insets were
horizontal/vertical/vertical/horizontal, and even if the first two had been
swapped, it would still function differently than other panel layouts.

BUG=none
TEST=none
==========

to

==========
Use the CreatePanelLayout() utility method instead of hand-rolling panel layout.

This is not only shorter, it fixes an issue where the provided insets didn't
make sense.  The expected order of insets is TLBR; the passed insets were
horizontal/vertical/vertical/horizontal, and even if the first two had been
swapped, it would still function differently than other panel layouts.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2668853002
Cr-Commit-Position: refs/heads/master@{#447404}
Committed:
https://chromium.googlesource.com/chromium/src/+/2dca6772888dd5454cafc6b50e2c...
==========

[commit-bot: I haz the power, 2017-02-01 01:45:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2dca6772888dd5454cafc6b50e2c...