Certificate Transparency: Discard entries pending auditing on network change

components/certificate_transparency/single_tree_tracker_unittest.cc

Index: components/certificate_transparency/single_tree_tracker_unittest.cc
diff --git a/components/certificate_transparency/single_tree_tracker_unittest.cc b/components/certificate_transparency/single_tree_tracker_unittest.cc
index adeb3780efeeff2406db9ae0174642918e2078a9..5be35d03cf517cd26e72f42abbca0e9064feb059 100644
--- a/components/certificate_transparency/single_tree_tracker_unittest.cc
+++ b/components/certificate_transparency/single_tree_tracker_unittest.cc
@@ -658,4 +658,24 @@ TEST_F(SingleTreeTrackerTest,
   histograms.ExpectBucketCount(kInclusionCheckResultHistogramName, 3, 1);
 }
 
+// Test that entries are no longer pending after a network state
+// change.
+TEST_F(SingleTreeTrackerTest, DiscardsPendingEntriesAfterNetworkChange) {
+  CreateTreeTrackerWithDefaultDnsExpectation();
+
+  base::HistogramTester histograms;
+  tree_tracker_->OnSCTVerified(chain_.get(), cert_sct_.get());
+
+  EXPECT_EQ(
+      SingleTreeTracker::SCT_PENDING_NEWER_STH,
+      tree_tracker_->GetLogEntryInclusionStatus(chain_.get(), cert_sct_.get()));
+
+  tree_tracker_->OnNetworkChanged(
+      net::NetworkChangeNotifier::CONNECTION_UNKNOWN);

[Ryan Sleevi, 2017/02/01 22:26:58]

Why are you pumping this method directly, rather than using the Mock you create
on line 169?

It would seem that it would better cover the test scenario (e.g. that you
remembered to register the STT as an NCO) by pumping the mock and making sure
it's reflected in the STT.

[Eran Messeri, 2017/02/02 14:54:40]

Done.

+
+  EXPECT_EQ(
+      SingleTreeTracker::SCT_NOT_OBSERVED,
+      tree_tracker_->GetLogEntryInclusionStatus(chain_.get(), cert_sct_.get()));
+}
+
 }  // namespace certificate_transparency