Certificate Transparency: Discard entries pending auditing on network change

components/certificate_transparency/single_tree_tracker_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_transparency/single_tree_tracker.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 640 matching lines @@
   // Exactly one value should be logged, indicating the SCT can be checked for
   // inclusion, as |tree_tracker_| did have a valid STH when it was notified
   // of a new SCT.
   histograms.ExpectTotalCount(kCanCheckForInclusionHistogramName, 1);
   histograms.ExpectBucketCount(kCanCheckForInclusionHistogramName, 2, 1);
   // Failure due to DNS configuration should be logged in the result histogram.
   histograms.ExpectTotalCount(kInclusionCheckResultHistogramName, 1);
   histograms.ExpectBucketCount(kInclusionCheckResultHistogramName, 3, 1);
 }
 
+// Test that entries are no longer pending after a network state
+// change.
+TEST_F(SingleTreeTrackerTest, DiscardsPendingEntriesAfterNetworkChange) {
+  CreateTreeTrackerWithDefaultDnsExpectation();
+
+  base::HistogramTester histograms;
+  tree_tracker_->OnSCTVerified(chain_.get(), cert_sct_.get());
+
+  EXPECT_EQ(
+      SingleTreeTracker::SCT_PENDING_NEWER_STH,
+      tree_tracker_->GetLogEntryInclusionStatus(chain_.get(), cert_sct_.get()));
+
+  tree_tracker_->OnNetworkChanged(
+      net::NetworkChangeNotifier::CONNECTION_UNKNOWN);

[Ryan Sleevi, 2017/02/01 22:26:58]

Why are you pumping this method directly, rather than using the Mock you create
on line 169?

It would seem that it would better cover the test scenario (e.g. that you
remembered to register the STT as an NCO) by pumping the mock and making sure
it's reflected in the STT.

[Eran Messeri, 2017/02/02 14:54:40]

Done.

+
+  EXPECT_EQ(
+      SingleTreeTracker::SCT_NOT_OBSERVED,
+      tree_tracker_->GetLogEntryInclusionStatus(chain_.get(), cert_sct_.get()));
+}
+
 }  // namespace certificate_transparency