MD Settings: Fix Learn More link on Google Hotword in ChromeOS

MD Settings: Fix Learn More link on Google Hotword in ChromeOS

Adds a new injected-dom slot in the settings-toggle element also.

BUG=687094
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668803003
Cr-Commit-Position: refs/heads/master@{#447426}
Committed: https://chromium.googlesource.com/chromium/src/+/05d2f9d809d9082c4447bafe1e1806fdbbc9e3a1

[tommycli, 2017-02-01 00:36:39]

Description was changed from

==========
MD Settings: Fix Learn More link on Google Hotword in ChromeOS

BUG=687094
R=stevenjb@chromium.org
==========

to

==========
MD Settings: Fix Learn More link on Google Hotword in ChromeOS

BUG=687094
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-02-01 00:37:14]

Description was changed from

==========
MD Settings: Fix Learn More link on Google Hotword in ChromeOS

BUG=687094
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix Learn More link on Google Hotword in ChromeOS

Adds a new injected-dom slot in the settings-toggle element also.

BUG=687094
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-02-01 00:37:23]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 00:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 00:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:41:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tommycli, 2017-02-01 00:48:46]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 00:49:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-01 00:51:13]

stevenjb: PTAL, thanks!

[stevenjb, 2017-02-01 00:53:18]

lgtm

[tommycli, 2017-02-01 00:56:15]

On 2017/02/01 00:53:18, stevenjb wrote:
> lgtm

thanks!

[Dan Beam, 2017-02-01 00:59:49]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-02-01 00:59:50]

https://codereview.chromium.org/2668803003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_toggle_button.html
(left):

https://codereview.chromium.org/2668803003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_toggle_button.html:45:
<content selector=".more-actions"></content>
so did this just not work before?

[tommycli, 2017-02-01 01:01:19]

https://codereview.chromium.org/2668803003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_toggle_button.html
(left):

https://codereview.chromium.org/2668803003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_toggle_button.html:45:
<content selector=".more-actions"></content>
On 2017/02/01 00:59:50, Dan Beam wrote:
> so did this just not work before?

There was only one slot before, so I guess it just selected everything.

[tommycli, 2017-02-01 01:01:35]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-02-01 01:01:35]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-02-01 01:01:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-02-01 01:02:10]

lgtm thanks for fixing

[tommycli, 2017-02-01 01:05:31]

On 2017/02/01 01:02:10, Dan Beam wrote:
> lgtm thanks for fixing

np. I'm out.

[commit-bot: I haz the power, 2017-02-01 02:42:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485910895906340,
"parent_rev": "ab0b37a4184cccbdd9ffaaaf5e95e56b415a0fbf", "commit_rev":
"05d2f9d809d9082c4447bafe1e1806fdbbc9e3a1"}

[commit-bot: I haz the power, 2017-02-01 02:43:13]

Description was changed from

==========
MD Settings: Fix Learn More link on Google Hotword in ChromeOS

Adds a new injected-dom slot in the settings-toggle element also.

BUG=687094
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix Learn More link on Google Hotword in ChromeOS

Adds a new injected-dom slot in the settings-toggle element also.

BUG=687094
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668803003
Cr-Commit-Position: refs/heads/master@{#447426}
Committed:
https://chromium.googlesource.com/chromium/src/+/05d2f9d809d9082c4447bafe1e18...
==========

[commit-bot: I haz the power, 2017-02-01 02:43:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05d2f9d809d9082c4447bafe1e18...