Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2668723002: Handle JS-calls in impact_test. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 2 chunks +10 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 3 chunks +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-01-31 15:37:36 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2668723002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart File pkg/compiler/lib/src/serialization/equivalence.dart (right): https://codereview.chromium.org/2668723002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart#newcode1072 pkg/compiler/lib/src/serialization/equivalence.dart:1072: impact2.nativeData, (a, b) => testNativeBehavior(a, b, strategy: strategy)); ...
3 years, 10 months ago (2017-01-31 21:51:47 UTC) #3
Johnni Winther
https://codereview.chromium.org/2668723002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart File pkg/compiler/lib/src/serialization/equivalence.dart (right): https://codereview.chromium.org/2668723002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart#newcode1072 pkg/compiler/lib/src/serialization/equivalence.dart:1072: impact2.nativeData, (a, b) => testNativeBehavior(a, b, strategy: strategy)); On ...
3 years, 10 months ago (2017-02-01 09:17:39 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-02-01 09:22:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1511bb8647e02aab9b3ca29ab15b1bf68ced524f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698