Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2668693006: Exclude a couple types of windows from CrOS Alt+Tab. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude a couple types of windows from CrOS Alt+Tab. Dragged windows and non-user-positionable windows won't appear in Alt+Tab. BUG=685247, 685435 Review-Url: https://codereview.chromium.org/2668693006 Cr-Commit-Position: refs/heads/master@{#447614} Committed: https://chromium.googlesource.com/chromium/src/+/f8aac2d7a75dbd08e7e91779f365bb54dbfabaaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M ash/common/wm/window_cycle_controller.cc View 2 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 10 months ago (2017-02-01 02:13:25 UTC) #3
oshima
lgtm
3 years, 10 months ago (2017-02-01 20:59:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668693006/1
3 years, 10 months ago (2017-02-01 21:24:33 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 21:30:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8aac2d7a75dbd08e7e91779f365...

Powered by Google App Engine
This is Rietveld 408576698