Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2668643002: [turbofan] Remove over-restrictive DCHECKs. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove over-restrictive DCHECKs. The KeyedStoreMode that we get out of the FeedbackNexus doesn't necessarily need to apply when we have "static knowledge" about the receiver, i.e. when the receiver is a known JSTypedArray, but the KEYED_STORE_IC has seen only JSArray instances so far. The DCHECK was too restrictive in this case, since we can just ignore the KEYED_STORE_IC mode (like we ignore the maps). BUG=chromium:685050 R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2668643002 Cr-Commit-Position: refs/heads/master@{#42810} Committed: https://chromium.googlesource.com/v8/v8/+/64eae6eff294670c4503d9a95fbe164e34edcdf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +0 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-685050.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-31 07:38:22 UTC) #1
Benedikt Meurer
Hey Igor, Easy one. Please take a look. Thanks, Benedikt
3 years, 10 months ago (2017-01-31 07:38:51 UTC) #4
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-31 08:31:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668643002/1
3 years, 10 months ago (2017-01-31 08:59:00 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 09:01:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/64eae6eff294670c4503d9a95fbe164e34e...

Powered by Google App Engine
This is Rietveld 408576698