Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2668633003: [Turbofan] Macro-ize instruction selection for arm64. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Macro-ize instruction selection for arm64. - Uses macros to reduce code duplication. - Uses calls to VisitRR and VisitRRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668633003 Cr-Commit-Position: refs/heads/master@{#42829} Committed: https://chromium.googlesource.com/v8/v8/+/e3aef1ccc25871cc30107594bf1ff55c8484a575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -313 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 7 chunks +80 lines, -313 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bbudge
3 years, 10 months ago (2017-02-01 01:37:43 UTC) #4
titzer
lgtm
3 years, 10 months ago (2017-02-01 01:43:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668633003/1
3 years, 10 months ago (2017-02-01 01:53:39 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 02:00:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e3aef1ccc25871cc30107594bf1ff55c848...

Powered by Google App Engine
This is Rietveld 408576698