Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2668633002: Sort camera device list to use front camera first (Closed)

Created:
3 years, 10 months ago by wuchengli
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Sort camera device list to use front camera first Since javascript doesn't have API to get camera facing, we sort the reported camera device list by facing. Then app can use the front camera by default. BUG=684224, chrome-os-partner:61756 TEST=powerwash device and camera app uses the front camera by default. Review-Url: https://codereview.chromium.org/2648973003 Cr-Commit-Position: refs/heads/master@{#446307} (cherry picked from commit e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875) Review-Url: https://codereview.chromium.org/2668633002 . Cr-Commit-Position: refs/branch-heads/2987@{#214} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e0221ccb1eea16293cff0c0a0cda5a110266a5d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M media/capture/video/linux/video_capture_device_factory_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/capture/video/video_capture_device_descriptor.h View 1 chunk +1 line, -5 lines 0 comments Download
M media/capture/video/video_capture_device_descriptor.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
3 years, 10 months ago (2017-01-31 03:05:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0221ccb1eea16293cff0c0a0cda5a110266a5d5.

Powered by Google App Engine
This is Rietveld 408576698