Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: tests/compiler/dart2js/kernel/impact_test.dart

Issue 2668623003: Check equivalence on impact computed with KernelWorldBuilder. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/impact_test.dart
diff --git a/tests/compiler/dart2js/kernel/impact_test.dart b/tests/compiler/dart2js/kernel/impact_test.dart
index 910aab8a470278477bde462f161a8e40a1cd5281..001591f0a3fcef0d4393f93897f9f8a82d20564f 100644
--- a/tests/compiler/dart2js/kernel/impact_test.dart
+++ b/tests/compiler/dart2js/kernel/impact_test.dart
@@ -11,11 +11,11 @@ import 'package:compiler/src/common/names.dart';
import 'package:compiler/src/common/resolution.dart';
import 'package:compiler/src/compiler.dart';
import 'package:compiler/src/constants/expressions.dart';
-import 'package:compiler/src/elements/resolution_types.dart';
import 'package:compiler/src/elements/elements.dart';
+import 'package:compiler/src/elements/resolution_types.dart';
import 'package:compiler/src/js_backend/backend.dart';
-import 'package:compiler/src/kernel/world_builder.dart';
import 'package:compiler/src/kernel/element_adapter.dart';
+import 'package:compiler/src/kernel/world_builder.dart';
import 'package:compiler/src/resolution/registry.dart';
import 'package:compiler/src/resolution/tree_elements.dart';
import 'package:compiler/src/ssa/kernel_impact.dart';
@@ -712,13 +712,19 @@ void checkElement(Compiler compiler, KernelElementAdapter kernelElementAdapter,
ResolutionImpact astImpact =
compiler.resolution.getResolutionImpact(element);
astImpact = laxImpact(compiler, element, astImpact);
- ResolutionImpact kernelImpact = build(compiler, element.resolvedAst);
+ ResolutionImpact kernelImpact1 = build(compiler, element.resolvedAst);
ir.Member member = getIrMember(compiler, element.resolvedAst);
- // TODO(johnniwinther): Check equivalence for the computed impact.
- buildKernelImpact(member, kernelElementAdapter);
- Expect.isNotNull(kernelImpact, 'No impact computed for $element');
- testResolutionImpactEquivalence(
- astImpact, kernelImpact, const CheckStrategy());
+ Expect.isNotNull(kernelImpact1, 'No impact computed for $element');
+ ResolutionImpact kernelImpact2 =
+ buildKernelImpact(member, kernelElementAdapter);
+ Expect.isNotNull(kernelImpact2, 'No impact computed for $member');
+ testResolutionImpactEquivalence(astImpact, kernelImpact1,
+ strategy: const CheckStrategy());
+ KernelEquivalence equivalence = new KernelEquivalence(kernelElementAdapter);
+ testResolutionImpactEquivalence(astImpact, kernelImpact2,
+ strategy: new CheckStrategy(
+ elementEquivalence: equivalence.entityEquivalence,
+ typeEquivalence: equivalence.typeEquivalence));
});
}
« no previous file with comments | « pkg/compiler/lib/src/serialization/equivalence.dart ('k') | tests/compiler/dart2js/serialization/test_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698