Check equivalence on impact computed with KernelWorldBuilder.

tests/compiler/dart2js/kernel/impact_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.kernel.impact_test;
 
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/commandline_options.dart';
 import 'package:compiler/src/common.dart';
 import 'package:compiler/src/common/names.dart';
 import 'package:compiler/src/common/resolution.dart';
 import 'package:compiler/src/compiler.dart';
 import 'package:compiler/src/constants/expressions.dart';
+import 'package:compiler/src/elements/elements.dart';
 import 'package:compiler/src/elements/resolution_types.dart';
-import 'package:compiler/src/elements/elements.dart';
 import 'package:compiler/src/js_backend/backend.dart';
+import 'package:compiler/src/kernel/element_adapter.dart';
 import 'package:compiler/src/kernel/world_builder.dart';
-import 'package:compiler/src/kernel/element_adapter.dart';
 import 'package:compiler/src/resolution/registry.dart';
 import 'package:compiler/src/resolution/tree_elements.dart';
 import 'package:compiler/src/ssa/kernel_impact.dart';
 import 'package:compiler/src/serialization/equivalence.dart';
 import 'package:compiler/src/universe/call_structure.dart';
 import 'package:compiler/src/universe/feature.dart';
 import 'package:compiler/src/universe/use.dart';
 import 'package:expect/expect.dart';
 import 'package:kernel/ast.dart' as ir;
 import '../memory_compiler.dart';
@@ skipping 676 matching lines @@
       return;
     }
   }
   if (!fullTest && !compiler.resolution.hasResolutionImpact(element)) {
     return;
   }
   compiler.reporter.withCurrentElement(element.implementation, () {
     ResolutionImpact astImpact =
         compiler.resolution.getResolutionImpact(element);
     astImpact = laxImpact(compiler, element, astImpact);
-    ResolutionImpact kernelImpact = build(compiler, element.resolvedAst);
+    ResolutionImpact kernelImpact1 = build(compiler, element.resolvedAst);
     ir.Member member = getIrMember(compiler, element.resolvedAst);
-    // TODO(johnniwinther): Check equivalence for the computed impact.
-    buildKernelImpact(member, kernelElementAdapter);
-    Expect.isNotNull(kernelImpact, 'No impact computed for $element');
-    testResolutionImpactEquivalence(
-        astImpact, kernelImpact, const CheckStrategy());
+    Expect.isNotNull(kernelImpact1, 'No impact computed for $element');
+    ResolutionImpact kernelImpact2 =
+        buildKernelImpact(member, kernelElementAdapter);
+    Expect.isNotNull(kernelImpact2, 'No impact computed for $member');
+    testResolutionImpactEquivalence(astImpact, kernelImpact1,
+        strategy: const CheckStrategy());
+    KernelEquivalence equivalence = new KernelEquivalence(kernelElementAdapter);
+    testResolutionImpactEquivalence(astImpact, kernelImpact2,
+        strategy: new CheckStrategy(
+            elementEquivalence: equivalence.entityEquivalence,
+            typeEquivalence: equivalence.typeEquivalence));
   });
 }
 
 /// Lax the precision of [impact] to meet expectancy of the corresponding impact
 /// generated from kernel.
 ResolutionImpact laxImpact(
     Compiler compiler, AstElement element, ResolutionImpact impact) {
   ResolutionWorldImpactBuilder builder =
       new ResolutionWorldImpactBuilder('Lax impact of ${element}');
   for (StaticUse staticUse in impact.staticUses) {
@@ skipping 120 matching lines @@
         visitList(type.optionalParameterTypes),
         type.namedParameters,
         visitList(type.namedParameterTypes));
   }
 }
 
 /// Perform unaliasing of all typedefs nested within a [ResolutionDartType].
 ResolutionDartType unalias(ResolutionDartType type) {
   return const Unaliaser().visit(type);
 }