Issue 2668623003: Check equivalence on impact computed with KernelWorldBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2668623003: Check equivalence on impact computed with KernelWorldBuilder. (Closed)

Created:
3 years, 10 months ago by Johnni Winther

Modified:
3 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+277 lines, -33 lines)			Patch
M	pkg/compiler/lib/src/kernel/element_adapter.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/kernel/elements.dart	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/kernel/world_builder.dart	View	4 chunks	+47 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/equivalence.dart	View	3 chunks	+45 lines, -17 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/impact_test.dart	View	2 chunks	+14 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/test_helper.dart	View	3 chunks	+161 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 10 months ago (2017-02-01 09:10:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3dfcafe5bedc2e20759e51d9c09d5ce77adbbbbb (presubmit successful).