Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)
Patch Set: One bot doesn't like 256 day timers. :( Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index 5cf4c797f6bc965104f3db194e463c66206a778d..3d8939bdc22974af6b8bc64675f54803cea977ea 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -2431,15 +2431,14 @@ TEST_P(ResourceDispatcherHostTest, TooManyOutstandingRequests) {
for (size_t i = 0; i < kMaxRequestsPerProcess; ++i)
CheckSuccessfulRequest(msgs[i], net::URLRequestTestJob::test_data_2());
- // TODO(mmenke): These should be failing with ERR_INSUFFICIENT_RESOURCES.
- // Update OnWillRead to use a ResourceController so it can fail with different
- // error codes.
CheckFailedRequest(msgs[kMaxRequestsPerProcess + 0],
- net::URLRequestTestJob::test_data_2(), net::ERR_ABORTED);
+ net::URLRequestTestJob::test_data_2(),
+ net::ERR_INSUFFICIENT_RESOURCES);
CheckSuccessfulRequest(msgs[kMaxRequestsPerProcess + 1],
net::URLRequestTestJob::test_data_2());
CheckFailedRequest(msgs[kMaxRequestsPerProcess + 2],
- net::URLRequestTestJob::test_data_2(), net::ERR_ABORTED);
+ net::URLRequestTestJob::test_data_2(),
+ net::ERR_INSUFFICIENT_RESOURCES);
second_filter->OnChannelClosing();
third_filter->OnChannelClosing();

Powered by Google App Engine
This is Rietveld 408576698