Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: content/browser/loader/redirect_to_file_resource_handler.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)
Patch Set: One bot doesn't like 256 day timers. :( Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/redirect_to_file_resource_handler.cc
diff --git a/content/browser/loader/redirect_to_file_resource_handler.cc b/content/browser/loader/redirect_to_file_resource_handler.cc
index b9784b0676e5317301edd21032dbba323dc3d94d..3bddfd75d301dfebfb755ebc993036685ed506f7 100644
--- a/content/browser/loader/redirect_to_file_resource_handler.cc
+++ b/content/browser/loader/redirect_to_file_resource_handler.cc
@@ -185,9 +185,10 @@ void RedirectToFileResourceHandler::OnWillStart(
}
}
-bool RedirectToFileResourceHandler::OnWillRead(
+void RedirectToFileResourceHandler::OnWillRead(
scoped_refptr<net::IOBuffer>* buf,
- int* buf_size) {
+ int* buf_size,
+ std::unique_ptr<ResourceController> controller) {
if (buf_->capacity() < next_buffer_size_)
buf_->SetCapacity(next_buffer_size_);
@@ -198,7 +199,7 @@ bool RedirectToFileResourceHandler::OnWillRead(
*buf_size = buf_->RemainingCapacity();
buf_write_pending_ = true;
- return true;
+ controller->Resume();
}
void RedirectToFileResourceHandler::OnReadCompleted(

Powered by Google App Engine
This is Rietveld 408576698