Not Remove Non-Closable Arc Popup When Close Button is Pressed

ui/arc/notification/arc_custom_notification_view.h

Index: ui/arc/notification/arc_custom_notification_view.h
diff --git a/ui/arc/notification/arc_custom_notification_view.h b/ui/arc/notification/arc_custom_notification_view.h
index 19864fa7c19a54cba8d57eff8e063219da2c7eec..be453cdfac3ffcd894726a8359ce1af02d9394b7 100644
--- a/ui/arc/notification/arc_custom_notification_view.h
+++ b/ui/arc/notification/arc_custom_notification_view.h
@@ -35,7 +35,7 @@ class ArcCustomNotificationView
       public ArcCustomNotificationItem::Observer,
       public ArcNotificationSurfaceManager::Observer {
  public:
-  explicit ArcCustomNotificationView(ArcCustomNotificationItem* item);
+  ArcCustomNotificationView(ArcCustomNotificationItem* item);

[xiyuan, 2017/03/02 20:39:51]

"explicit" is required for single arg constructor per style guide.

https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

[yoshiki, 2017/03/03 01:22:04]

Done.

   ~ArcCustomNotificationView() override;
 
   std::unique_ptr<message_center::CustomNotificationContentViewDelegate>
@@ -87,7 +87,7 @@ class ArcCustomNotificationView
   void OnNotificationSurfaceAdded(exo::NotificationSurface* surface) override;
   void OnNotificationSurfaceRemoved(exo::NotificationSurface* surface) override;
 
-  ArcCustomNotificationItem* item_ = nullptr;
+  ArcCustomNotificationItem* item_;

[xiyuan, 2017/03/02 20:39:51]

nit: Why do we need to change this? It would be useful if the constructor is
changed later and forget to initialize this.

[yoshiki, 2017/03/03 01:22:04]

Oops, you're right. Reverted.

   exo::NotificationSurface* surface_ = nullptr;
 
   const std::string notification_key_;